Skip to content

PEP 752: Address feedback, round 1 #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 21, 2024

  1. Changed most uses of the word "package" to "project".
  2. Explicitly state that PEP 708 does not offer protection against these types of dependency confusion attacks.
  3. Changed the semantics to be based on the project rather than individual artifacts. It appears it's more useful to consider the current namespace permissions rather than if a version was part of the namespace at the time of release.
  4. As a consequence of 2, removed recommended fields in the Simple API.
  5. Added optional top-level owner and namespace keys to the JSON API.
  6. Added NPM-style scoping explicitly as a rejected idea and enumerate all of the rationale.
  7. Rather than giving permission to users, made it clear that authorization for uploads is about identical project and grant owners.
  8. Made it clear that private root grants may create public child grants and the reverse is only possible when the owner also happens to own every project that matches the namespace.
  9. PEP 752: Add more examples #3912 (comment)

📚 Documentation preview 📚: https://pep-previews--3916.org.readthedocs.build/

@ofek ofek requested a review from warsaw as a code owner August 21, 2024 17:20
@ofek ofek force-pushed the pep-752/feedback branch from 857ba15 to e7796c5 Compare August 21, 2024 17:53
@ofek ofek mentioned this pull request Aug 21, 2024
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small questions.

@warsaw warsaw merged commit 05bf9c5 into python:main Aug 21, 2024
6 checks passed
@ofek ofek deleted the pep-752/feedback branch August 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants