Skip to content

update apple soc info #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 29, 2025
Merged

update apple soc info #290

merged 7 commits into from
May 29, 2025

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented May 1, 2025 •
edited
Loading

@kimishpatel
[WIP] update apple soc info
a71b7b5 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 1, 2025
@kimishpatel
[WIP] update apple soc info
be23b9b 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3b1b804
Pull Request resolved: #290
@digantdesai
Copy link
Contributor

what's left here?

@kimishpatel
Update on "[WIP] update apple soc info"
bb44bb9 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 28, 2025
@kimishpatel
Update apple soc info
8e6eeb0 
Summary:
Added support for A16, A17, A18, A18 pro. Reg values are found from ncnn
and needs validation

Test Plan:
Add test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: bfd0535
Pull Request resolved: #290
@kimishpatel
Copy link
Contributor Author

what's left here?

updated now. Left out M series. Need to figure out how to test.

@kimishpatel
Update on "[WIP] update apple soc info"
8a7ea9d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 28, 2025
@kimishpatel
Update apple soc info
3be4ff2 
Summary:
Added support for A16, A17, A18, A18 pro. Reg values are found from ncnn
and needs validation

Test Plan:
Add test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5fb9c98
Pull Request resolved: #290
@kimishpatel
Update on "[WIP] update apple soc info"
8f9b523 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 28, 2025
@kimishpatel
Update apple soc info
d36aac8 
Summary:
Added support for A16, A17, A18, A18 pro. Reg values are found from ncnn
and needs validation

Test Plan:
Add test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f089252
Pull Request resolved: #290
@kimishpatel kimishpatel changed the title [WIP] update apple soc info update apple soc info May 28, 2025
@kimishpatel
Update on "update apple soc info"
23759e8 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 28, 2025
@kimishpatel
Update apple soc info
bc3cd55 
Summary:
Added support for A16, A17, A18, A18 pro. Reg values are found from ncnn
and needs validation

Test Plan:
Add test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f917ea4
Pull Request resolved: #290
@digantdesai
Copy link
Contributor

Clang format issues? Not sure what's up with risc-v. Let me rerun? Also rebas, IIRC @malfet fixed them after I jumped the trigger and merged bad PRs.

Also for testing, what is the plan? It seems harmless but just checking.

@kimishpatel
Copy link
Contributor Author

Clang format issues? Not sure what's up with risc-v. Let me rerun? Also rebas, IIRC @malfet fixed them after I jumped the trigger and merged bad PRs.

Also for testing, what is the plan? It seems harmless but just checking.

clang format is for things not touched by this diff though

@malfet
Copy link
Contributor

malfet commented May 28, 2025 •
edited
Loading

@kimishpatel please rebase your PR
Also add some description on what are the sources of those names

@kimishpatel
Copy link
Contributor Author

@kimishpatel please rebase your PR Also add some description on what are the sources of those names

let me rebase. this was based on ghstack. Code points to where these values come from

@kimishpatel kimishpatel changed the base branch from gh/kimishpatel/1/base to main May 28, 2025 23:45
kimishpatel added a commit that referenced this pull request May 29, 2025
@kimishpatel
Update apple soc info
2745f80 
Summary:
Added support for A16, A17, A18, A18 pro. Reg values are found from ncnn
and needs validation

Test Plan:
Add test

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e7b5ddf
Pull Request resolved: #290
@kimishpatel kimishpatel merged commit c61fe91 into main May 29, 2025
13 checks passed
@kimishpatel kimishpatel mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimishpatel @digantdesai @malfet @facebook-github-bot