Move examples/models/... out of the torch namespace
#5318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 39b248c with merge base 67be84b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
force-pushed
the
export-D62591348
branch
from
0e125dc to
ada5783
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Differential Revision: D62591348
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
force-pushed
the
export-D62591348
branch
from
ada5783 to
fc13f26
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Differential Revision: D62591348
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Differential Revision: D62591348
dbort
force-pushed
the
export-D62591348
branch
from
fc13f26 to
fcf9102
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Differential Revision: D62591348
dbort
force-pushed
the
export-D62591348
branch
from
fcf9102 to
2b56aa3
Compare
larryliu0820
approved these changes
Sep 13, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Reviewed By: larryliu0820 Differential Revision: D62591348
dbort
force-pushed
the
export-D62591348
branch
from
2b56aa3 to
a899417
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
force-pushed
the
export-D62591348
branch
from
a899417 to
304b4ba
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Reviewed By: larryliu0820 Differential Revision: D62591348
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
force-pushed
the
export-D62591348
branch
from
304b4ba to
16def7e
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Reviewed By: larryliu0820 Differential Revision: D62591348
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Reviewed By: larryliu0820 Differential Revision: D62591348
dbort
force-pushed
the
export-D62591348
branch
from
16def7e to
8558bb9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Reviewed By: larryliu0820 Differential Revision: D62591348
dbort
force-pushed
the
export-D62591348
branch
from
8558bb9 to
d56e800
Compare
Summary: Pull Request resolved: pytorch#5318 The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. I made one non-mechanical change in llama_tiktoken.h: we should always use `enum class` to avoid polluting the parent namespace, and enum values should follow UpperSnakeCase. Tests: Should be a no-op; CI passes. Prints no output: ``` find examples/models -type f | xargs grep "namespace torch" find examples/models -type f | xargs grep "namespace executorch" ``` Build llava_main: ``` bash .ci/scripts/test_llava.sh ``` Reviewed By: larryliu0820 Differential Revision: D62591348
|
This pull request was exported from Phabricator. Differential Revision: D62591348 |
dbort
force-pushed
the
export-D62591348
branch
from
d56e800 to
39b248c
Compare
|
This pull request has been merged in 262dfc0. |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 20, 2024
Fix the build errors I introduced in pytorch#5318 Test Plan: Build the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md
Closed
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 20, 2024
Fix the build errors I introduced in pytorch#5318 Test Plan: Build the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Summary: Fix the build errors I introduced in #5318 Pull Request resolved: #5513 Test Plan: Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md Reviewed By: helunwencser Differential Revision: D63133231 Pulled By: dbort fbshipit-source-id: 81d5402e76fd86c919a13a1b1b83687feca72ab7
pytorchbot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Summary: Fix the build errors I introduced in #5318 Pull Request resolved: #5513 Test Plan: Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md Reviewed By: helunwencser Differential Revision: D63133231 Pulled By: dbort fbshipit-source-id: 81d5402e76fd86c919a13a1b1b83687feca72ab7 (cherry picked from commit 8618607)
Merged
jackzhxng
pushed a commit
that referenced
this pull request
Sep 22, 2024
Fix phi-3-mini build (#5513) Summary: Fix the build errors I introduced in #5318 Pull Request resolved: #5513 Test Plan: Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md Reviewed By: helunwencser Differential Revision: D63133231 Pulled By: dbort fbshipit-source-id: 81d5402e76fd86c919a13a1b1b83687feca72ab7 (cherry picked from commit 8618607) Co-authored-by: Dave Bort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The code under examples/... is a proxy for user code, and users should never declare code under the
torch::orexecutorch::namespaces.Move this code under the
example::namespace to make it more clear that users should use their own namespaces when writing code like this.I made one non-mechanical change in llama_tiktoken.h: we should always use
enum classto avoid polluting the parent namespace, and enum values should follow UpperSnakeCase.Differential Revision: D62591348