Fix phi-3-mini build #5513
Closed
Fix phi-3-mini build #5513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5513
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 896d4dc with merge base af098c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fix the build errors I introduced in pytorch#5318 Test Plan: Build the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
helunwencser
approved these changes
Sep 20, 2024
|
@pytorchbot cherry-pick --onto release/0.4 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Summary: Fix the build errors I introduced in #5318 Pull Request resolved: #5513 Test Plan: Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md Reviewed By: helunwencser Differential Revision: D63133231 Pulled By: dbort fbshipit-source-id: 81d5402e76fd86c919a13a1b1b83687feca72ab7 (cherry picked from commit 8618607)
Cherry picking #5513The cherry pick PR is at #5522 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 22, 2024
Fix phi-3-mini build (#5513) Summary: Fix the build errors I introduced in #5318 Pull Request resolved: #5513 Test Plan: Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md Reviewed By: helunwencser Differential Revision: D63133231 Pulled By: dbort fbshipit-source-id: 81d5402e76fd86c919a13a1b1b83687feca72ab7 (cherry picked from commit 8618607) Co-authored-by: Dave Bort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build errors I introduced in #5318
Test Plan:
Built the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md