Skip to content

Qualcomm AI Engine Direct - ConvFormer Enablement #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  1. Enable new script: ConvFormer
  2. Support new op builder: adaptive_average_pool_2d
  3. Reduce consecutive transpose for multi output case or transpose with shape such as [0,1,2,3]

Test plan

Added test cases for ConvFormer and adaptive_average_pool_2d
Command:
python backends/qualcomm/tests/test_qnn_delegate.py -k TestExampleOssScript.test_conv_former --model SM8650 --host your_host --device your_device --build_folder build-android -r ./ -a path_to_artifacts -i path_to_dataset

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_adaptive_avg_pool2d --model SM8650 --host your_host --device your_device --build_folder build-android

Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6654

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e2606fe with merge base 90a2657 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to enable ConvFormer.
I have the details written in the summary section.
Please have a look.
Thanks

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ConvFormer_Enablement branch from d4d8438 to 2f1353b Compare November 20, 2024 09:25
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Nov 22, 2024

Hi @winskuo-quic , looks like lots of CI are failing, but I feel like they're unrelated. Can you help with rebasing and see if they're gone? Thanks!

@cccclai cccclai added the release notes: backends [DO NOT USE] Changes to any of the backend delegates label Nov 22, 2024
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ConvFormer_Enablement branch from 2f1353b to e5fba53 Compare November 29, 2024 02:31
@winskuo-quic
Copy link
Collaborator Author

Hi @winskuo-quic , looks like lots of CI are failing, but I feel like they're unrelated. Can you help with rebasing and see if they're gone? Thanks!

Hi @cccclai,
Sorry for the late response.
I have just rebased to the mainline. Please have a look.
Thanks.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/ConvFormer_Enablement branch from e5fba53 to e2606fe Compare January 24, 2025 07:05
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit d17f45b into pytorch:main Jan 30, 2025
46 checks passed
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: backends [DO NOT USE] Changes to any of the backend delegates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants