Skip to content

[dim order] reenbale dim order as default #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Dec 9, 2024

Stack from ghstack (oldest at bottom):

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: D66970153

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Dec 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7252

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit cc7fd8a with merge base b9db0a3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66970153

Gasoonjia added a commit that referenced this pull request Dec 9, 2024
This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)

ghstack-source-id: 257249663
Pull Request resolved: #7252
@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Dec 9, 2024
Pull Request resolved: #7252

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)
ghstack-source-id: 257301598
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66970153

@facebook-github-bot facebook-github-bot merged commit f2b299c into gh/Gasoonjia/6/base Dec 11, 2024
42 of 46 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/Gasoonjia/6/head branch December 11, 2024 08:42
kirklandsign pushed a commit that referenced this pull request Dec 16, 2024
Pull Request resolved: #7252

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)
ghstack-source-id: 257301598

Co-authored-by: gasoonjia <[email protected]>
@mergennachin
Copy link
Contributor

@pytorchbot revert

Copy link

pytorch-bot bot commented Jan 2, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message, -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@mergennachin
Copy link
Contributor

@pytorchbot revert -m revert dim order to fix nightly and viable strict builds -c ignoredsignal

Copy link

pytorch-bot bot commented Jan 2, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: dim order to fix nightly and viable strict builds

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@mergennachin
Copy link
Contributor

@pytorchbot revert -m "revert dim order to fix nightly and viable strict builds" -c ignoredsignal

@Gasoonjia
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.5 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Jan 15, 2025
Differential Revision: D66970153

Pull Request resolved: #7252

(cherry picked from commit f2b299c)
@pytorchbot
Copy link
Collaborator

Cherry picking #7252

The cherry pick PR is at #7682 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

SS-JIA pushed a commit that referenced this pull request Jan 17, 2025
Differential Revision: D66970153

Pull Request resolved: #7252

(cherry picked from commit f2b299c)

Co-authored-by: Gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants