Skip to content

[dim order] reenbale dim order as default #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7252
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/6/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/6/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/6/orig
@diff-train-skip-merge

Pull Request resolved: #7252

This diff reenable dim order as default feature in ExecuTorch stack.

Differential Revision: [D66970153](https://our.internmc.facebook.com/intern/diff/D66970153/)
ghstack-source-id: 257301598
Copy link

pytorch-bot bot commented Dec 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7288

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 3d2f344 with merge base b9db0a3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
@kirklandsign kirklandsign merged commit 6158674 into main Dec 16, 2024
41 of 46 checks passed
@kirklandsign kirklandsign deleted the gh/Gasoonjia/6/orig branch December 16, 2024 22:20
@kimishpatel
Copy link
Contributor

@pytorchbot revert -m "revert dim order to fix nightly and viable strict builds" -c ignoredsignal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants