Skip to content

Make serial parallel_for "polyfill" iterate backwards in debug builds #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Mar 11, 2025
Merged

Make serial parallel_for "polyfill" iterate backwards in debug builds #9044

merged 52 commits into from
Mar 11, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 7, 2025

Catches users who assume it goes forwards in order (like my attempt to use parallel_for in reductions, whoops).

swolchok added 30 commits March 4, 2025 11:35
@swolchok
Update
d0b11e8 
[ghstack-poisoned]
@swolchok
Update
9437be1 
[ghstack-poisoned]
@swolchok
Update
643e10e 
[ghstack-poisoned]
@swolchok
Update
6f2842b 
[ghstack-poisoned]
@swolchok
Update
e47dfeb 
[ghstack-poisoned]
@swolchok
Update
231ebc3 
[ghstack-poisoned]
@swolchok
Update
296513c 
[ghstack-poisoned]
@swolchok
Update
845a01e 
[ghstack-poisoned]
@swolchok
Update
a92958a 
[ghstack-poisoned]
@swolchok
Update
3fa99d6 
[ghstack-poisoned]
@swolchok
Update
a6c69a6 
[ghstack-poisoned]
@swolchok
Update
3bd6437 
[ghstack-poisoned]
@swolchok
Update
675f01b 
[ghstack-poisoned]
@swolchok
Update
5f3a768 
[ghstack-poisoned]
@swolchok
Update
9fdebee 
[ghstack-poisoned]
@swolchok
Update
70a7096 
[ghstack-poisoned]
@swolchok
Update
337dc23 
[ghstack-poisoned]
@swolchok
Update
f388177 
[ghstack-poisoned]
@swolchok
Update
2949daf 
[ghstack-poisoned]
@swolchok
Update
7347915 
[ghstack-poisoned]
@swolchok
Update
1a8481d 
[ghstack-poisoned]
@swolchok
Update
e48e816 
[ghstack-poisoned]
@swolchok
Update
3351d50 
[ghstack-poisoned]
@swolchok
Update
0102e25 
[ghstack-poisoned]
@swolchok
Update
a1aeae7 
[ghstack-poisoned]
@swolchok
Update
c658163 
[ghstack-poisoned]
@swolchok
Update
7e0ccd4 
[ghstack-poisoned]
@swolchok
Update
d9cd27c 
[ghstack-poisoned]
@swolchok
Update
c130224 
[ghstack-poisoned]
@swolchok
Update
754a4f6 
[ghstack-poisoned]
swolchok added 5 commits March 10, 2025 18:19
@swolchok
Update
c0d1daa 
[ghstack-poisoned]
@swolchok
Update
4917358 
[ghstack-poisoned]
@swolchok
Update
4a43b35 
[ghstack-poisoned]
@swolchok
Update
73f37ee 
[ghstack-poisoned]
@swolchok
Update
a8dd330 
[ghstack-poisoned]
This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
Merged
JacobSzwejbka
JacobSzwejbka approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug loop looks fine to me, though do we have much other NDEBUG ifdefs in the codebase? Is that a mode people often use with ET?

@swolchok
Copy link
Contributor Author

Is that a mode people often use with ET?

Release builds define NDEBUG. it's the same macro that gates assert.

Base automatically changed from gh/swolchok/315/head to main March 11, 2025 18:14
@swolchok
Update
142c537 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 11, 2025
@swolchok
Make parallel_for iterate backwards in debug builds
895abbb 
Catches users who assume it goes forwards in order (like my attempt to use parallel_for in reductions, whoops).

ghstack-source-id: 4fa2978
ghstack-comment-id: 2707052203
Pull Request resolved: #9044
@swolchok swolchok merged commit 8f7bc8d into main Mar 11, 2025
17 of 19 checks passed
@swolchok swolchok deleted the gh/swolchok/324/head branch March 11, 2025 18:24
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok mentioned this pull request Mar 12, 2025
Merged
swolchok added a commit that referenced this pull request Mar 12, 2025
@swolchok
Revert "Revert "Split & remove extension_parallel (#8983)""
c8aeeea 
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
SS-JIA pushed a commit that referenced this pull request Mar 12, 2025
@swolchok
Revert "Make serial parallel_for "polyfill" iterate backwards in debu…
498795b 
…g builds (#9044)" (#9188)

This reverts commit 8f7bc8d.
swolchok added a commit that referenced this pull request Mar 12, 2025
@swolchok
Revert "Revert "Split & remove extension_parallel (#8983)""
5b02e54 
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
@swolchok
Revert "Revert "Split & remove extension_parallel (#8983)""
7486bd3 
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
@swolchok
Revert "Revert "Split & remove extension_parallel (#8983)"" (#9190)
6ba6e3e 
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in
debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in
unittest-buck) (#9159)""

This reverts commit 10bb615.
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@dbort dbort Awaiting requested review from dbort

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

@tarun292 tarun292 Awaiting requested review from tarun292

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@cccclai cccclai Awaiting requested review from cccclai

@metascroy metascroy Awaiting requested review from metascroy

@cymbalrush cymbalrush Awaiting requested review from cymbalrush

@mergennachin mergennachin Awaiting requested review from mergennachin

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@digantdesai digantdesai Awaiting requested review from digantdesai

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @JacobSzwejbka @facebook-github-bot