Unbreak optimized kernels buck build (and check it in unittest-buck) #9159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9159
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 62 PendingAs of commit fe70c14 with merge base 8f7bc8d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Mar 11, 2025
Found a missing buck dep on import to internal repo. ghstack-source-id: d97072265da867f1bdb327824061b3e59d85c09d ghstack-comment-id: 2715647590 Pull Request resolved: #9159
SS-JIA
approved these changes
Mar 11, 2025
swolchok
changed the title
|
landing on the strength of linux unittest-buck pass. mac job is queued but I ran it locally during development. |
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a missing buck dep on import to internal repo.