Add tutorial for swap_tensors in nn.Module #2824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A branch to test 2.3 tutorials
Disable usb_semisup_learn
* Update export tutorial --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2824
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7dff2ed with merge base 2c231da ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
force-pushed
the
swap
branch
3 times, most recently
from
ae7bfca to
05995f9
Compare
svekars
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Thanks so much @mikaylagawarecki! Looks great - I added a few editorial suggestions - feel free to add/ignore as needed.
svekars
reviewed
Apr 8, 2024
albanD
reviewed
Apr 9, 2024
| # Notably, the existing approach does not work in these cases: | ||
| # | ||
| # * when using ``__torch_dispatch__`` subclasses | ||
| # * when ``param`` and ``new_param`` do not have the same type |
There was a problem hiding this comment.
I think you need to define "type" here.
There was a problem hiding this comment.
Updated to say "Python type()", do you think this is sufficiently expressive?
* [export] Remove interactive aoti compilation --------- Co-authored-by: Svetlana Karslioglu <[email protected]>
svekars
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title