Rename features.SegmentationMask to features.Mask #6579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Sep 14, 2022
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Summary: * rename features.SegmentationMask -> features.Mask * rename kernels *_segmentation_mask -> *_mask and cleanup input name * cleanup * rename module _segmentation_mask.py -> _mask.py * fix test Reviewed By: jdsgomes Differential Revision: D39543280 fbshipit-source-id: 72d5e209b45025df16047513ce1b3910d44fd352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6574 (comment).
The following individual things were done:
features.SegmentationMasktofeatures.Masktorchvision.prototype.features._segmentation_masktotorchvision.prototype.features._mask*_segmentation_maskto*_maskmaskmake_detection_and_segmentation_maskstomake_maskssegmentation_masktomaskI'm aware this will be a pain to review. I used my IDE to refactor and searched for all appropriate strings afterwards. I'm fairly confident, I did cover everything. Locally, all tests and
mypyare passing so this is an extra layer of confidence. Let's hope our CI agrees.