Skip to content

TensorFlow June pin update & PyTorch/XLA c++17 migration (follow up) #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 15, 2022
Merged

TensorFlow June pin update & PyTorch/XLA c++17 migration (follow up) #3794

merged 13 commits into from
Aug 15, 2022

Conversation

miladm
Copy link
Collaborator

@miladm miladm commented Jul 29, 2022 •
edited
Loading

@miladm miladm mentioned this pull request Jul 29, 2022
Closed
@miladm
Copy link
Collaborator Author

miladm commented Jul 29, 2022 •
edited
Loading

@wonjoolee95 this change is breaking test in this CI.

@wonjoolee95
Copy link
Collaborator

wonjoolee95 commented Jul 29, 2022 •
edited
Loading

@wonjoolee95 this change is breaking test in this CI.

Hmm that PR should actually fix the error shown on the CI, could you try doing a quick rebase on master?

@miladm
Copy link
Collaborator Author

miladm commented Aug 13, 2022

Turns out the absence of -Wno-c++11-narrowing breaks pytorch tests and the absence of -Wno-c++14-narrowing breaks the pytorch/xla build. So, I added both flags and this seems to be working!!

CC @JackCaoG @yeounoh

@miladm miladm self-assigned this Aug 13, 2022
@miladm miladm merged commit 6639bcc into master Aug 15, 2022
@miladm miladm mentioned this pull request Aug 17, 2022
Merged
JackCaoG added a commit that referenced this pull request Sep 3, 2022
@JackCaoG
Revert "TensorFlow June pin update & PyTorch/XLA c++17 migration (fol…
1f79e32 
…low up) (#3794)"

This reverts commit 6639bcc.
@JackCaoG JackCaoG mentioned this pull request Sep 3, 2022
Closed
JackCaoG added a commit that referenced this pull request Sep 5, 2022
@JackCaoG
Revert "TensorFlow June pin update & PyTorch/XLA c++17 migration (fol…
51a68a1 
…low up) (#3794)"

This reverts commit 6639bcc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-cromar will-cromar will-cromar approved these changes

@JackCaoG JackCaoG Awaiting requested review from JackCaoG

@yeounoh yeounoh Awaiting requested review from yeounoh

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

Assignees

@miladm miladm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miladm @wonjoolee95 @will-cromar