Skip to content

TensorFlow June pin update & PyTorch/XLA c++17 migration (follow up) #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 15, 2022
Merged

TensorFlow June pin update & PyTorch/XLA c++17 migration (follow up) #3794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7e9c8bf
adding tf pin
miladm Jul 1, 2022
04a217d
moving tf pin to a week back when tf had a successful pin - jun 22
miladm Jul 1, 2022
c1fffb9
pin update, some debug prints - to remove later
miladm Jul 21, 2022
0836d1d
moved pytorch/xla to c++17
miladm Jul 25, 2022
5e55956
adding torch pin for testing
miladm Jul 25, 2022
6d1239c
adding torch pin for testing
miladm Jul 25, 2022
38ad6e8
adding torch pin for testing
miladm Jul 25, 2022
ead3454
adding c++17 to CMakeLists.txt
miladm Jul 26, 2022
7a6686b
removed torch pin
miladm Jul 26, 2022
9c264f6
removing the environment variable
miladm Jul 29, 2022
b8520c2
type
miladm Jul 29, 2022
04a46c5
moving back to -Wno-c++11-narrowing
miladm Aug 12, 2022
9122ce4
trying both c++11 and c++14 narrowing
miladm Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build_torch_xla_libs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ if [[ ! -z "$BAZEL_JOBS" ]]; then
MAX_JOBS="--jobs=$BAZEL_JOBS"
fi

OPTS+=(--cxxopt="-std=c++14")
OPTS+=(--cxxopt="-std=c++17")
if [[ $(basename -- $CC) =~ ^clang ]]; then
OPTS+=(--cxxopt="-Wno-c++11-narrowing")
OPTS+=(--cxxopt="-Wno-c++14-narrowing")
fi

if [[ "$XLA_CUDA" == "1" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def make_relative_rpath(path):


extra_compile_args = [
'-std=c++14',
'-std=c++17',
'-Wno-sign-compare',
'-Wno-deprecated-declarations',
'-Wno-return-type',
Expand Down
2 changes: 2 additions & 0 deletions test/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ ExternalProject_Add(
CMAKE_ARGS
"-DCMAKE_CXX_FLAGS=-D_GLIBCXX_USE_CXX11_ABI=${PT_CXX_ABI}")

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17")

ExternalProject_Get_Property(googletest SOURCE_DIR)

set(TORCH_XLA_TEST_SOURCES
Expand Down
2 changes: 1 addition & 1 deletion third_party/tensorflow
Open in desktop
Submodule tensorflow updated 4236 files