Include torchax in torch_xla #8895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/scan-shard-as
branch
from
5f84ac1 to
9dcfe1c
Compare
tengyifei
force-pushed
the
yifeit/torchax-in-torch-xla
branch
from
8eb87ca to
a67cc9c
Compare
tengyifei
force-pushed
the
yifeit/torchax-in-torch-xla
branch
2 times, most recently
from
8bb02d4 to
4c4ca93
Compare
zpcore
reviewed
Apr 2, 2025
zpcore
reviewed
Apr 2, 2025
qihqi
approved these changes
Apr 4, 2025
tengyifei
force-pushed
the
yifeit/torchax-in-torch-xla
branch
from
13a631b to
8621943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8831
This PR changes the
torch_xlabuild such thattorchaxis automatically included, instead of being a separate install.This motivation is to support features like #8893 and others that use
xb.call_jaxand requirestorchax. Instead of yelling at the user to installtorchax, it's easier to just install it for them.Because
torchaxusesjax, we'll just automatically installjaxall the time. As a result, I removed all thepip install torch_xla[pallas]andpip install torchaxcommands from our CI scripts in this repo.This PR should be backwards compatible because any existing standalone
torchaxinstalls will be overwritten to use the copy fromtorch_xla, and anypip install torch_xla[pallas]commands will become no-op instead of failing.