Skip to content

Remove bazel #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balopat opened this issue Jul 1, 2021 · 2 comments · Fixed by #4297
Closed

Remove bazel #4280

balopat opened this issue Jul 1, 2021 · 2 comments · Fixed by #4297
Labels
area/google/protos area/google kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@balopat
Copy link
Contributor

balopat commented Jul 1, 2021

Description of the issue

Now that there is no dependency of TFQ on our protos (tensorflow/quantum#590), we can remove all the bazel functionality.

@balopat balopat added kind/health For CI/testing/release process/refactoring/technical debt items area/google area/google/protos labels Jul 1, 2021
@95-martin-orion
Copy link
Collaborator

How does this interact with Google-internal usage of Cirq, which is (or will soon be) required for QCS? Presumably, the internal code relies on internal Bazel for building Cirq - we should make sure that those definitions are preserved (even if they move to internal-only).

We can discuss the internal Cirq requirements offline if you have questions.

@balopat
Copy link
Contributor Author

balopat commented Jul 8, 2021

My understanding is that it does not interact with it at all. The BUILD/WORKSPACE files are all excluded in the copybara imports and have instead alternative versions controlled internally for blaze (otherwise internal targets would need to be open sourced, which would not be too meaningful).

CirqBot pushed a commit that referenced this issue Jul 9, 2021
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/google/protos area/google kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants