Remove bazel from repo

[MichaelBroughton]

Fixes #4280

[balopat]

I think it is useful to have a job that checks for whether the checked-in pb2 files are up to date with the protos or not. Thus, we should keep the grpc_tools generation part. Also, this might be a good point to clean up the duplication between this job and dev_tools/build-protos.sh.

[balopat]

Thanks for picking this up! I'd keep a simplified version of the build-changed-protos job.

[MichaelBroughton]

How do you propose we keep an alternate version of the build-changed-protos job ? Reading through it a little more closely I'm actually a little surprised we had it in the first place. All it really did was build the protos against the current version of grpcio. It did no follow up tests or version checks of any kind against other parts of the library (that I can find).

Are you thinking we add some kind of test that actually builds new pb2 files from the .proto files on the repo and do some functionality tests there ?

[balopat]

How do you propose we keep an alternate version of the build-changed-protos job ? Reading through it a little more closely I'm actually a little surprised we had it in the first place. All it really did was build the protos against the current version of grpcio. It did no follow up tests or version checks of any kind against other parts of the library (that I can find).

Are you thinking we add some kind of test that actually builds new pb2 files from the .proto files on the repo and do some functionality tests there ?

This script did test whether the proto definitions are consistent with the pb2 files or not, based on the assumption that previously they were. If that assumption is true, and the proto files change, the pb2 files might change. In that case the developer should commit the new version of the pb2 file. If they forgot to do that, these lines check whether there is a change simply using git after rebuilding the pb2 files using grpcio:

https://github.com/quantumlib/Cirq/pull/4297/files#diff-bc40ce42a88c1b3c04e7c0248a1094cf47ad7b088e6f549c0b8987dfb4ff1e91L100-L112

[balopat]

This is a better link: https://github.com/quantumlib/Cirq/blob/master/check/build-changed-protos#L98-L112

[MichaelBroughton]

Ok, so do we want to just keep these "change checker" style of tests from the build-changed-protos and leave it at that then ?

[balopat]

Ok, so do we want to just keep these "change checker" style of tests from the build-changed-protos and leave it at that then ?

Yes!

[balopat]

LGTM

[CirqBot]

Automerge cancelled: A required status check is not present.

Missing statuses: ['Changed files test', 'Format check']