Implemented 8n T complexity decomposition of LessThanEqual gate #6156
Conversation
|
@mpharrigan this is now ready for review @babbush @Strilanc fyi this is an implementation of your design. |
| if context is None: | ||
| context = cirq.DecompositionContext(cirq.ops.SimpleQubitManager()) | ||
|
|
||
| P, Q, target = (qubits[: self.x_bitsize], qubits[self.x_bitsize : -1], qubits[-1]) |
There was a problem hiding this comment.
can we use pep8 variable names here
why are we not using GateWithRegisters?
There was a problem hiding this comment.
this gate was created as a cirq.ArithmeticGate, should I change that?
There was a problem hiding this comment.
It can be done later, but I think would work nicely here since you manually have to segregate the qubits into registers during decomposte at present.
|
this is ready for another look @mpharrigan |
| if d == 0: | ||
| return infra.TComplexity(t=8 * n - 4, clifford=46 * n - 17) | ||
| elif d == 1: | ||
| return infra.TComplexity(t=8 * n, clifford=46 * n + 3 + 2 * is_second_longer) | ||
| else: | ||
| return infra.TComplexity( | ||
| t=8 * n + 4 * d - 4, clifford=46 * n + 17 * d - 14 + 2 * is_second_longer | ||
| ) |
| def _has_unitary_(self): | ||
| return True |
| # TODO: Do not decompose {cq.And, cq.LessThanEqualGate, cq.LessThanGate} because the | ||
| # `cq.map_clean_and_borrowable_qubits` currently gets confused and is not able to re-map qubits | ||
| # optimally; which results in a higher number of ancillas thus the tests fails due to OOO. |
|
@mpharrigan this is ready for another look |
|
|
||
| from cirq._compat import cached_property |
There was a problem hiding this comment.
question: why can't we use functools.cached_property in cirq?
| @@ -130,6 +131,147 @@ def _t_complexity_(self) -> infra.TComplexity: | |||
| ) | |||
|
|
|||
|
|
|||
| @attr.frozen | |||
| class BiQubitsMixer(infra.GateWithRegisters): | |||
| """Implements the COMPARE2 (Fig. 1) https://www.nature.com/articles/s41534-018-0071-5#Sec8 | |||
There was a problem hiding this comment.
this links to the acknowledgements section lol. Please remove the #Sec8.
There was a problem hiding this comment.
sec8 is the "Electronic supplementary material" which is where the decomposition is. it's not part of the main paper but is in the supplementary material
This is the Comparison Oracle from https://static-content.springer.com/esm/art%3A10.1038%2Fs41534-018-0071-5/MediaObjects/41534_2018_71_MOESM1_ESM.pdf