Implemented 8n T complexity decomposition of LessThanEqual gate #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanujkhattar this is now ready for review |
That was @ncrubin |
mpharrigan
reviewed
May 22, 2023
mpharrigan
reviewed
May 22, 2023
Comment on lines
+191
to
+192
| def _has_unitary_(self): | ||
| return True |
There was a problem hiding this comment.
I don't think this is necessary(?)
There was a problem hiding this comment.
it's needed until cirq.unitary starts to support gates/operations that allocate ancilla, without it some tests fail
|
If this is from a paper, please cite it! |
|
@mpharrigan added citation |
|
what's going on with this? will you re-open against cirq-ft? |
|
@mpharrigan yes. closed in favour of quantumlib/Cirq#6156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
Comparison Oraclefrom https://static-content.springer.com/esm/art%3A10.1038%2Fs41534-018-0071-5/MediaObjects/41534_2018_71_MOESM1_ESM.pdfpart of #112