Skip to content

Enable all feature flags when deploying a new cluster #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkuratczyk opened this issue Oct 27, 2020 · 0 comments · Fixed by #434
Closed

Enable all feature flags when deploying a new cluster #414

mkuratczyk opened this issue Oct 27, 2020 · 0 comments · Fixed by #434
Assignees
Milestone

Comments

@mkuratczyk
Copy link
Collaborator

Some feature flags are disabled by default because RabbitMQ itself cannot tell whether it's starting a fresh node or not at the time it needs to decide the state of a feature flag. To be on the safe side - those flags are disabled. The operator however, can distinguish between a fresh cluster deployment and update/upgrade and should therefore enable all feature flags when deploying a new cluster so that all features are available by default. At this time, these disabled-by-default feature flags are drop_unroutable_metric and empty_basic_get_metric but ideally, we should make the implementation generic so that we always enable all feature flags when deploying a new cluster.

@mkuratczyk mkuratczyk added this to the GA milestone Oct 27, 2020
@ansd ansd self-assigned this Oct 28, 2020
ansd added a commit that referenced this issue Oct 29, 2020
ansd added a commit that referenced this issue Oct 30, 2020
ansd added a commit that referenced this issue Oct 30, 2020
@ansd ansd closed this as completed in #434 Nov 3, 2020
ansd added a commit that referenced this issue Nov 3, 2020
* Enable all feature flags for new clusters

Closes #414

* Rename post deploy to CLI

because the RabbitMQ CLI commands get executed at the end of the
reconcile loop which does not necessarily mean that a deployment just finished.

This commit also fixes a bug where the rabbitmq-plugins command was run on
every successful reconile loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants