Enable all feature flags for new clusters #434
Conversation
There was a problem hiding this comment.
I'm not sure if we should move the set plugins functionality to "post deploy", given that there are cases where the plugins might be updated without a (re)deploy. For example, by updating the CR with rabbitmq_federation, the plugin is enabled and the cluster should not be restarted.
because the RabbitMQ CLI commands get executed at the end of the reconcile loop which does not necessarily mean that a deployment just finished. This commit also fixes a bug where the rabbitmq-plugins command was run on every successful reconile loop.
|
@Zerpet good point, previously we ran "post deploy" at the end of every successful reconcile loop. The post deploy flag still exists and can be extended with other RabbitMQ CLI commands in future. |
|
I think there is something wrong with the functionality. It works if I just However, I wanted to make sure it would not enable feature flags for pre-existing clusters so I deployed from |
|
Please ignore my comment above. Because we removed double prefix in |
Closes #414
Notes:
createdof the StatefulSet.rabbitmq.com/createdAtis added onto the created StatefulSet.rabbitmqctl enable_feature_flagis used on the first pod of the StatefulSet to enable all stable and previously disabled feature flags. (In future, we could add feature flag methods to https://github.com/michaelklishin/rabbit-hole/ to not exec into the pod anymore.)