Skip to content

Make terminationGracePeriodSeconds configuration at rabbitmqcluster.spec #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChunyiLyu opened this issue Oct 27, 2020 · 0 comments · Fixed by #430
Closed

Make terminationGracePeriodSeconds configuration at rabbitmqcluster.spec #419

ChunyiLyu opened this issue Oct 27, 2020 · 0 comments · Fixed by #430

Comments

@ChunyiLyu
Copy link
Contributor

ChunyiLyu commented Oct 27, 2020

Context

As discussed in sync-up, it's an important context that we should make people aware that we intentionally set terminationGracePeriodSeconds to a week long to ensure that no data loss during a restart of pods. We decided to 1) document this week long timeout and make people aware that this could cause long termination for pods 2) make this timeout configurable at the top level since we are aware that not all people want this feature.

Describe the solution you'd like

kind: RabbitmqCluster
spec:
  terminationGracePeriodSeconds: # configurable and [defaults to 604800](https://github.com/rabbitmq/cluster-operator/blob/main/internal/resource/statefulset.go#L30)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mkuratczyk mkuratczyk modified the milestone: GA Oct 27, 2020
ChunyiLyu added a commit that referenced this issue Oct 27, 2020
ChunyiLyu added a commit that referenced this issue Oct 29, 2020
ChunyiLyu added a commit that referenced this issue Oct 29, 2020
- related to issue #419 
- make TerminationGracePeriodSeconds configurable
- refactor to use "k8s.io/utils/pointer" library everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants