Make TerminationGracePeriodSeconds configurable #424
Conversation
- related to issue #419
|
@ChunyiLyu could you add more details to the PR or issue as to why this value is made configurable? |
|
@ansd added more context in the issue. |
There was a problem hiding this comment.
I'm thinking that we should adapt the timeout in the preStop hooks to match the termination grace period i.e. rabbitmq-upgrade await_online_quorum_plus_one -t 604800. And perhaps remove the preStop hook altogether if the grace period is set to 0.
What do you think?
| // For more information, see: https://github.com/rabbitmq/cluster-operator/blob/main/docs/design/20200520-graceful-pod-termination.md | ||
| // +kubebuilder:validation:Minimum:=0 | ||
| // +kubebuilder:default:=604800 | ||
| TerminationGracePeriodSeconds *int64 `json:"terminationGracePeriodSeconds,omitempty"` |
There was a problem hiding this comment.
Does omitempty have any effect? Given that we set a default and value 0 is also an acceptable value, I think this field will never be empty.
There was a problem hiding this comment.
Without omitempty, defaulting won't work here. See commit
|
Merge conflicts in this branch is hard to resolve. Moved to PR #430 Closing |
This closes #419
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Additional Context
Local Testing
Have run unit, integration, and system tests