Accept Cache Key for Inline & Preloaded Module in Importmap Tag #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rience
force-pushed
the
pass-importmap-json-tags
branch
from
2cab3c1 to
5a59187
Compare
|
Let's solve this via #187 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have multi-tenant application and needed to generate different importmap tags for each tenant. I can see in #88 that some helpers already support passing custom cache keys, however,
javascript_importmap_tagsdoes not support that.I couldn't make application working by rendering only
javascript_inline_importmap_tagandjavascript_importmap_module_preload_tagsin<head />. I'm not sure about othershimones andjavascript_import_module_taghelpers - they needed to be in there.So that PR allows you to pass in custom cache keys to
javascript_importmap_tags.into
javascript_importmap_tags.