Add support for passing a custom importmap to the tag helper #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a great feature whenever you have separate areas of the application with completely different sets of dependencies. The most common example of that is admin areas, both on the main Rails application or coming from engines.
elia
force-pushed
the
elia/custom-importmap
branch
3 times, most recently
from
978e2ff to
311d7eb
Compare
This is meant to be temporary.
elia
force-pushed
the
elia/custom-importmap
branch
from
f0328d9 to
997f30b
Compare
|
For some reason calling JSPM via Net::HTTP returns a 503, wasn't able to reproduce it locally but I confirmed that |
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Jun 14, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
3 tasks
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Jun 15, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Jun 15, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
dhh
reviewed
Jun 18, 2023
lib/importmap/packager.rb
Outdated
| @@ -110,6 +110,8 @@ def remove_package_from_importmap(package) | |||
| end | |||
|
|
|||
| def download_package_file(package, url) | |||
| return `curl -s '#{url}' > #{vendored_package_path(package)}` if url =~ /jspm.io/ | |||
There was a problem hiding this comment.
Need to treat this as a separate change.
This was referenced Jun 18, 2023
Remove unrelated change
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Jun 19, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Jul 11, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Aug 2, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
waiting-for-dev
pushed a commit
to solidusio/solidus
that referenced
this pull request
Aug 8, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
waiting-for-dev
pushed a commit
to solidusio/solidus
that referenced
this pull request
Aug 9, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Sep 25, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Sep 27, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Sep 28, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Sep 28, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Sep 29, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
elia
added a commit
to solidusio/solidus
that referenced
this pull request
Oct 6, 2023
- The helper is identical to the original one except for defaults and passing a custom importmap (see rails/importmap-rails#187) - The reloading configuration is a simplified version of the one in importmap-rails, same for the reloader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great feature whenever you have separate areas of the application with completely different sets of dependencies.
The most common example of that is admin areas, both on the main Rails application or coming from engines.
SpinaCMS for example had to add a custom helper https://github.com/SpinaCMS/Spina/blob/400821ddd27aad76c0ff29ac603fb934b5d7e648/app/helpers/spina/spina_helper.rb