fix react-native 0.74 Use invalidate method instead onCatalystInstanceDestroy #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a289459798
changed the title
|
Is there an open issue related to this? |
|
#1106, I reckon. |
5 tasks
tido64
reviewed
Jul 18, 2024
| @@ -81,7 +81,7 @@ public void initialize() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void onCatalystInstanceDestroy() { | |||
| public void invalidate() { | |||
There was a problem hiding this comment.
invalidate was introduced in 0.65: facebook/react-native@18c8417#diff-736ae7997f3da9751f0f5cf756d8ce4401190bda205c894acc77efe959bd1ecb
Our package.json says we still support 0.60:
In order to make this change, we will also need to bump the minimum version to 0.65. This means we will have to make a major release.
And since onCatalystInstanceDestroy was removed in 0.74, it looks like this is the simpler path than maintaining two AsyncStorageModule.java.
There was a problem hiding this comment.
Agreed, let's bump to min 0.65 and do major release
|
Superseded by #1124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan