fix(android): replace onCatalystInstanceDestroy with invalidate
#1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e63a73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tido64
force-pushed
the
tido/support-0.74
branch
from
63a7339 to
5e63a73
Compare
krizzu
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onCatalystInstanceDestroywas removed in 0.74, replaced byinvalidate.However,
invalidatewas introduced in 0.65: facebook/react-native@18c8417#diff-736ae7997f3da9751f0f5cf756d8ce4401190bda205c894acc77efe959bd1ecbAnd our
package.jsonsays we still support 0.60:async-storage/packages/default-storage/package.json
Line 69 in fbd4ccf
In order to make this change, we will also need to bump the minimum version to 0.65. This means we will have to make a major release.
Resolves #1106.
Test Plan
CI should pass.