Modify the failing tests #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttanimichi
force-pushed
the
modify-failing-tests
branch
from
d1c8aa4 to
82db5e5
Compare
```
Error:
PagesControllerTest#test_it_mounts_components_from_the_dev_server:
RuntimeError: Failed to start dev server
/home/travis/build/reactjs/react-rails/test/support/webpacker_helpers.rb:65:in `with_dev_server'
/home/travis/build/reactjs/react-rails/test/react/rails/pages_controller_test.rb:32:in `block (2 levels) in <class:PagesControllerTest>'
```
Related to rails/webpacker#1179
``` Failure: WebpackerManifestContainerTest#test_it_loads_JS_from_the_webpacker_container [/Users/tanimichi.tsukuru/ghq/github.com/reactjs/react-rails/test/react/server_rendering/webpacker_manifest_container_test.rb:20]: Expected "...(snip)....js.map" to include "ExportDefaultComponent". ``` Now `webpacker:compile` doesn't contain components' name in the javascript_pack_tags. I think we shouldn't test the contents in `application.js` because it's an implementation detail of webpacker and depending on it makes our tests fragile.
ttanimichi
force-pushed
the
modify-failing-tests
branch
from
82db5e5 to
fa6e8f6
Compare
|
All tests were passed successfully 🎉 cc: @BookOfGreg @suhailnaw
|
|
@BookOfGreg I've merged this by myself. Feel free to revert them if they aren’t appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892 and #894
415096a
fa6e8f6