fix: default update thread for actions is EDT (#218) #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Dietisheim <[email protected]>
|
sbouchet
reviewed
Apr 10, 2024
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| IJ: [IC-2021.1, IC-2021.2, IC-2021.3, IC-2022.1, IC-2022.2, IC-2022.3, IC-2023.1, IC-2023.2] | |||
| IJ: [IC-2022.3, IC-2023.1, IC-2023.2, IC-2024.1] | |||
There was a problem hiding this comment.
means all dependent extensions using next version need to validate this range version too ?
There was a problem hiding this comment.
I'd think so, yes. Agree?
There's not much choice: if the override is in commons, it needs to build against 2022.3+.
Alternatively we need to change all actions (or the super-classes they may have) in all plugins.
There was a problem hiding this comment.
here are the min. supported versions that we have currently:
- intellij-kubernetes is at
IC-2022.1
(https://github.com/redhat-developer/intellij-kubernetes/blob/1f4637041eb0a0b36fb86a6589f1370f9406d702/.github/workflows/IJ.yml#L17) - intellij-openshift-connector is at
IC-2022.1
(https://github.com/redhat-developer/intellij-openshift-connector/blob/30e4bc351d8df6a8058cf0d443706ab48cd2fed5/.github/workflows/validate_IJ_versions.yml#L12) - intellij-tekton is at
IC-2022.2
(https://github.com/redhat-developer/intellij-tekton/blob/84f3d264c06b98290bcf88626d86fa8f5a085dd7/.github/workflows/IJ.yml#L17) - intellij-knative is at
IC-2022.1
(https://github.com/redhat-developer/intellij-knative/blob/2e3c49bd684f27383a049c740e96f5e28a4f8ea4/.github/workflows/IJ.yml#L17)
There was a problem hiding this comment.
agree to move up to at least 22.3 for all downstream extensions. not a big step.
This was referenced Apr 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #218