Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text field for the current namespace isn't displayed at times #637

Closed
adietish opened this issue Jul 21, 2023 · 27 comments · Fixed by #638 or #745
Closed

Text field for the current namespace isn't displayed at times #637

adietish opened this issue Jul 21, 2023 · 27 comments · Fixed by #638 or #745
Labels
kind/bug Something isn't working severity/major
Milestone

Comments

@adietish
Copy link
Collaborator

adietish commented Jul 21, 2023

I cannot replicate this (I'm on Mac), it was reported by @olkornii (using Linux) while doing the integration tests. It happens to him maybe 2 out of 3 times

Steps:

  1. EXEC: In the resource tree: select the "Namespaces" category. Right click on it and pick "Set Current Namespace" (if you are using a kubernetes cluster. If it's OpenShift it's "Set Current Project"

Result:
A dialog shows up, that allows you to type the name of the namespace to use as current namespace. At times the dialog shows up without the text field (on Linux, not on Mac. Dont know about Windows)
image

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jul 21, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jul 21, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jul 21, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jul 21, 2023
@adietish
Copy link
Collaborator Author

@olkornii: @JessicaJHee tried to replicate it on Linux but she couldn't. Things worked well for her. Maybe this was caused by your slow cluster?

@adietish adietish self-assigned this Jul 21, 2023
@adietish adietish added kind/bug Something isn't working severity/major labels Jul 21, 2023
@adietish adietish added this to the 1.1.0 milestone Jul 21, 2023
adietish added a commit that referenced this issue Jul 21, 2023
@adietish
Copy link
Collaborator Author

Reopening since we are not sure if the change in #638 is fixing the issue. We could not replicate. PR still has value and was therefore merged.

@adietish adietish reopened this Jul 21, 2023
@olkornii
Copy link
Collaborator

@adietish appears for me with minikube locally as well. So probably is not caused by slow cluster.
Screenshot from 2023-07-24 10-02-13

@olkornii
Copy link
Collaborator

@JessicaJHee Can I ask you to try again. For example, I had to try around 20 times to reproduce...
Steps: Right click -> Set namespace -> Close

@JessicaJHee
Copy link
Member

@olkornii I'm quite lost on why I'm not able to reproduce it :( I tried again with more than 20 times and it works as expected each time.

@adietish
Copy link
Collaborator Author

@JessicaJHee thanks for trying again :)

@olkornii
Copy link
Collaborator

olkornii commented Jul 25, 2023

@JessicaJHee Could you share your OS, Java version, cluster name and version please?
It's really weird. I'm the only one who can reproduce this bug :D

@rgrunber rgrunber moved this from ✅ Done to 📋 Backlog in IDE Cloudaptors Jul 25, 2023
@adietish adietish modified the milestones: 1.1.0, 1.2.0 Jul 25, 2023
@JessicaJHee
Copy link
Member

@olkornii Sure!

OS: Fedora 35
Java Version: openjdk 17.0.3 2022-04-19
Cluster: minikube, v1.29.0

@adietish adietish moved this from 📋 Backlog to 🏗 In progress in IDE Cloudaptors Jul 25, 2023
@adietish adietish moved this from 🏗 In progress to 📋 Backlog in IDE Cloudaptors Aug 16, 2023
@mohitsuman mohitsuman removed this from the 1.2.0 milestone Sep 20, 2023
@adietish adietish removed their assignment Feb 21, 2024
@adietish
Copy link
Collaborator Author

adietish commented Feb 21, 2024

@olkornii: can you still reproduce this?

@mohitsuman
Copy link
Collaborator

@olkornii can you please verify this issue and let us know if this is still reproducible?

@mohitsuman mohitsuman modified the milestones: 1.3.0, 1.4.0 Apr 3, 2024
@olkornii
Copy link
Collaborator

olkornii commented Apr 3, 2024

Hi @adietish and @mohitsuman, I'll check it tomorrow.

@olkornii
Copy link
Collaborator

olkornii commented Apr 4, 2024

@adietish
Tried again with Fedora 39 CSB. Can not reproduce anymore.
But I noticed another strange behavior. Not sure if this is plugin related or not. Need one more person to check.

The steps are the same:
Right click "Namespaces" -> "Set Current Namespace" (HERE) -> close (HERE)

HERE: when clicked, fedora creates a new workspace for 1-2 seconds and deletes it. This is easy to see by the rectangles in the lower right corner of the screen.

@mohitsuman
Copy link
Collaborator

@adietish can you look at this for fedora OS ? If this is a new issue, let's track that separately and close this one.

@olkornii
Copy link
Collaborator

olkornii commented Apr 9, 2024

@adietish @mohitsuman While testing version 1.3.0, I noticed this bug again.

Unable to reproduce with IJ 2022.1 but easy to reproduce with 2024.1.
The steps are the same. Now this error is stable, the field appears only once and every next time there is no input field.

@mohitsuman
Copy link
Collaborator

@adietish can you please look at this ?

@adietish
Copy link
Collaborator Author

adietish commented Apr 9, 2024

@mohitsuman, @olkornii: I dont have fedora, I can only check in MacOS and I still cannot replicate this. Neither in IC-2022.1 nor IC-2024.1 (Screenshot is IC-2024.1)
image
Maybe @sbouchet can try to replicate this on Fedora?

@adietish
Copy link
Collaborator Author

@olkornii:

  • what's your jdk when you face this issue?
  • what's your desktop (gnome?)?
  • what's your desktop theme?

@olkornii
Copy link
Collaborator

olkornii commented Apr 10, 2024

@adietish

  1. java --version: openjdk 11.0.22 2024-01-16, tried with 17 as well
  2. Gnome 45.5
  3. Adwaita

@sbouchet
Copy link
Collaborator

sbouchet commented Apr 10, 2024

@adietish : i also can reproduce on 24.1 only ( 23.3 is working fine )
Fedora 39
Gnome 45.5
X11
Java 17.0.10

console logs:

2024-04-10 15:15:43,314 [ 299488] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.redhat.devtools.intellij.kubernetes]
com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.redhat.devtools.intellij.kubernetes]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)
2024-04-10 15:15:43,315 [ 299489] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - IntelliJ IDEA 2024.1  Build #IU-241.14494.240
2024-04-10 15:15:43,315 [ 299489] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - JDK: 17.0.10; VM: OpenJDK 64-Bit Server VM; Vendor: JetBrains s.r.o.
2024-04-10 15:15:43,315 [ 299489] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - OS: Linux
2024-04-10 15:15:43,315 [ 299489] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - Plugin to blame: Kubernetes by Red Hat version: 1.2.3.294

@adietish
Copy link
Collaborator Author

@olkornii: you did not change gradle.properties and you are therefore running IC-2022.1 (you can verify using Menu About IntelliJ IDEA), correct?

@olkornii
Copy link
Collaborator

I changed gradle.properties to 2024.1 for testing, as we discussed.

@adietish
Copy link
Collaborator Author

adietish commented Apr 10, 2024

@olkornii: ok, so we can confirm that this occurs with latest IC-2024.1 on Linux.

@adietish
Copy link
Collaborator Author

@olkornii, @sbouchet: if we can confirm that the above stacktrace is responsible for this,

2024-04-10 15:15:43,314 [ 299488] SEVERE - #com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction - `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.redhat.devtools.intellij.kubernetes]
com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.redhat.devtools.intellij.kubernetes.actions.SetCurrentNamespaceAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.redhat.devtools.intellij.kubernetes]

we'd have to bump min. supported IDEA version to IC-2022.3. See redhat-developer/intellij-openshift-connector#738

@adietish
Copy link
Collaborator Author

adietish commented Apr 11, 2024

@sbouchet, @olkornii: With fix: default update thread for actions is EDT (#218) in commons the stacktrace should not happen any more and this error should be fixed.
Can you please verify?

@olkornii
Copy link
Collaborator

Hi @adietish , I've tried once more and still can reproduce. @sbouchet can I ask you to try as well?

@sbouchet
Copy link
Collaborator

will try to reproduce with latest snapshot.

@sbouchet
Copy link
Collaborator

still there:
Capture d’écran du 2024-04-15 12-00-03

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 15, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 15, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Apr 15, 2024
adietish added a commit that referenced this issue Apr 16, 2024
@adietish adietish modified the milestones: 1.4.0, 1.3.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working severity/major
Projects
None yet
5 participants