Skip to content

if the kubeconfig is invalid, the tool window stays empty #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adietish opened this issue Dec 20, 2024 · 2 comments · Fixed by #810
Closed

if the kubeconfig is invalid, the tool window stays empty #809

adietish opened this issue Dec 20, 2024 · 2 comments · Fixed by #810
Assignees
Labels
kind/bug Something isn't working severity/critical
Milestone

Comments

@adietish
Copy link
Collaborator

adietish commented Dec 20, 2024

Steps:

  1. ASSERT: have an invalid kube config
    (ex. minikube port which is invalid/out of bounds server: "https://192.168.105.4:84437777", the correct port is 8443)
  2. EXEC: launch plugin

Result:
The toolkit window stays empty.
Image

@adietish
Copy link
Collaborator Author

adietish commented Dec 20, 2024

The reason is that when the client is created an exception is thrown. The exception then is swallowed, and the list of contexts stays empty. It should still create the context.

AllContexts:

override val all: List<IContext>
	get() {
		lock.write {
			if (_all.isEmpty()) {
				try {
					val all = createContexts(client.get(), client.get()?.config)
					_all.addAll(all)
				} catch (e: Exception) {
====>					//
				}
			}
			return _all
		}
	}

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Dec 20, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Dec 20, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Dec 20, 2024
@adietish
Copy link
Collaborator Author

Furthermore, there's no healing. Correcting the config file wont heal the toolkit window. It stays empty.

@adietish adietish assigned adietish and unassigned adietish Dec 26, 2024
@adietish adietish self-assigned this Jan 7, 2025
@adietish adietish added kind/bug Something isn't working severity/critical labels Jan 7, 2025
@adietish adietish moved this to 📋 Backlog in IDE Cloudaptors Jan 7, 2025
@adietish adietish moved this from 📋 Backlog to 📝 In Progress in IDE Cloudaptors Jan 14, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 14, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 14, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 14, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 16, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 16, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 16, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 20, 2025
@adietish adietish changed the title if the cluster is unreachable then toolkit window stays empty if the kubeconfig is invalid, the tool window stays empty Jan 20, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
@adietish adietish moved this from 📝 In Progress to 👀 In review in IDE Cloudaptors Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 21, 2025
@adietish adietish linked a pull request Jan 22, 2025 that will close this issue
adietish added a commit that referenced this issue Jan 23, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jan 23, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 23, 2025
adietish added a commit that referenced this issue Jan 24, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 27, 2025
@adietish adietish added this to the 1.5.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working severity/critical
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant