Skip to content

fix: display kubeconfig parse error on startup (#809) #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: display kubeconfig parse error on startup (#809) #810

merged 1 commit into from
Jan 23, 2025

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Dec 20, 2024 •
edited
Loading

@adietish adietish self-assigned this Dec 20, 2024
@adietish adietish force-pushed the issue-809 branch 8 times, most recently from 3af151c to 7841562 Compare January 21, 2025 10:33
@adietish adietish marked this pull request as ready for review January 21, 2025 10:33
@adietish adietish requested a review from sbouchet January 21, 2025 10:33
@adietish adietish changed the title fix: allow to refresh all contexts (#809) fix: display kubeconfig parse error on startup (#809) Jan 21, 2025
@adietish
Copy link
Collaborator Author

@sbouchet: to test this:

Steps:

  1. ASSERT: have an invalid kube config
    (ex. minikube port which is invalid/out-of-bounds: "https://192.168.105.4:84437777", the correct port is 8443)
  2. EXEC: launch plugin

Result:
The toolkit window stays empty.

Next step:

  1. EXEX: correct the port

Result:
The tree heals: the error is replaced by the contexts.

Thanks for reviewing this!

@adietish adietish force-pushed the issue-809 branch 3 times, most recently from 14501b4 to 4727cb9 Compare January 21, 2025 14:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adietish adietish mentioned this pull request Jan 21, 2025
Closed
@adietish adietish linked an issue Jan 22, 2025 that may be closed by this pull request
if the kubeconfig is invalid, the tool window stays empty #809
Closed
sbouchet
sbouchet approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement ! LGTM.

@adietish adietish merged commit cb23184 into redhat-developer:main Jan 23, 2025
16 checks passed
@adietish adietish deleted the issue-809 branch January 23, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if the kubeconfig is invalid, the tool window stays empty
2 participants
@adietish @sbouchet