Skip to content

fix: dont set dialog size, make dialog undecorated (#637) #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: dont set dialog size, make dialog undecorated (#637) #745

merged 1 commit into from
Apr 16, 2024

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Apr 15, 2024 •
edited
Loading

fixes #637

@adietish adietish requested a review from sbouchet April 15, 2024 13:20
@adietish adietish self-assigned this Apr 15, 2024
@adietish adietish changed the title dont set dialog size, make dialog undecorated (#637) fix: dont set dialog size, make dialog undecorated (#637) Apr 15, 2024
sbouchet
sbouchet approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, looks ok on fedora 39 with 24.1.

@sbouchet sbouchet requested a review from olkornii April 15, 2024 13:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adietish
Copy link
Collaborator Author

Ignoring IT failure since it is caused by a change in base IC and needs fixing.

olkornii
olkornii approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@olkornii olkornii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with 2024.1. Set Current Namespace works :)

@adietish adietish merged commit 9f97baa into redhat-developer:main Apr 16, 2024
12 of 13 checks passed
@adietish adietish deleted the issue-637 branch April 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

@olkornii olkornii olkornii approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text field for the current namespace isn't displayed at times
3 participants
@adietish @sbouchet @olkornii