test: disable service tests #933
Conversation
Signed-off-by: Stephane Bouchet <[email protected]>
sbouchet
force-pushed
the
disable_services_tests
branch
from
b8a4d67 to
f5ae176
Compare
| private static final String PROJECT_NAME = "newtestproject"; | ||
|
|
||
| @Test | ||
| @Order(1) | ||
| @Disabled |
There was a problem hiding this comment.
Can we please add a comment so that we know why we disabled this test?
| echo -n "." | ||
| sleep 1 | ||
| nb=`kubectl get pods -n operators --no-headers --ignore-not-found | grep Running | wc -l` | ||
| done |
There was a problem hiding this comment.
do I get it right that these creates are not needed any more because you disabled the service tests?
Wouldn't it be preferrable to comment these since the tests also still exist but are disabled?
There was a problem hiding this comment.
yeah iagree to comment out because the test is disabled and not removed.
| env: | ||
| GPG_PASSPHRASE: ${{ secrets.IDEA_KEY_PASSPHRASE }} | ||
| run: | | ||
| echo -n "$GPG_PASSPHRASE" | gpg --decrypt --passphrase-fd 0 --pinentry-mode loopback --output idea_license_token/idea.key idea_license_token/idea.key.gpg | ||
| export DISPLAY=:99.0 | ||
| Xvfb -ac :99 -screen 0 1920x1080x16 & | ||
| sleep 10 | ||
| ./gradlew publicIntegrationUITest --continue --no-daemon | ||
| ./gradlew publicIntegrationUITest --continue |
There was a problem hiding this comment.
Wouldn't it be preferrable to rename the gradle task since we renamed the github task?
Something like:
./gradlew noContextIntegrationUITest --continueThere was a problem hiding this comment.
this PR does still use old gradle build, so still using the old naming
| @@ -1,41 +0,0 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Can you please explain why we're removing these fixtures?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adietish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbouchet ITs are still failing because they are run against the main branch, correct? |
Signed-off-by: Stephane Bouchet <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
|
/override "Cluster Integration UI Tests Report" "Public Integration UI Tests Report" ci/prow/e2e-openshift |
|
@adietish: Overrode contexts on behalf of adietish: Cluster Integration UI Tests Report, Public Integration UI Tests Report, ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 5909d85
into
redhat-developer:main
What is the purpose of this change? What does it change?
Disable flaky UI Integration tests that fails our checks.
Was the change discussed in an issue?
How to test changes?