This repository was archived by the owner on Apr 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
test: disable service tests #933
Merged
openshift-merge-bot
merged 2 commits into
redhat-developer:main
from
sbouchet:disable_services_tests
Oct 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
name: Public Integration UI Tests | ||
name: Integration UI Tests with No Context | ||
on: | ||
workflow_run: | ||
workflows: [ "Java CI with Gradle" ] | ||
types: | ||
- completed | ||
jobs: | ||
public-integration-ui-tests: | ||
no-context-integration-ui-tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
@@ -23,23 +23,23 @@ jobs: | |
validate-wrappers: true | ||
- name: Grant execute permission for gradlew | ||
run: chmod +x gradlew | ||
- name: Play public integration UI tests | ||
- name: Play integration UI tests | ||
env: | ||
GPG_PASSPHRASE: ${{ secrets.IDEA_KEY_PASSPHRASE }} | ||
run: | | ||
echo -n "$GPG_PASSPHRASE" | gpg --decrypt --passphrase-fd 0 --pinentry-mode loopback --output idea_license_token/idea.key idea_license_token/idea.key.gpg | ||
export DISPLAY=:99.0 | ||
Xvfb -ac :99 -screen 0 1920x1080x16 & | ||
sleep 10 | ||
./gradlew publicIntegrationUITest --continue --no-daemon | ||
./gradlew publicIntegrationUITest --continue | ||
- name: Publish tests reports | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't it be preferrable to rename the gradle task since we renamed the github task? ./gradlew noContextIntegrationUITest --continue There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this PR does still use old gradle build, so still using the old naming |
||
if: always() | ||
uses: scacap/action-surefire-report@a2911bd1a4412ec18dde2d93b1758b3e56d2a880 #v1.8.0 | ||
with: | ||
github_token: ${{secrets.GITHUB_TOKEN}} | ||
report_paths: '${{github.workspace}}/build/test-results/**/TEST-*.xml' | ||
commit: ${{github.event.workflow_run.head_sha}} | ||
check_name: Public Integration UI Tests Report | ||
check_name: Integration UI Tests with No Context Report | ||
- name: Publish screenshots as artifacts | ||
if: failure() | ||
uses: actions/upload-artifact@v4 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,8 @@ | |
package org.jboss.tools.intellij.openshift.test.ui; | ||
|
||
import com.intellij.remoterobot.RemoteRobot; | ||
import com.intellij.remoterobot.utils.WaitForConditionTimeoutException; | ||
import com.redhat.devtools.intellij.commonuitest.fixtures.dialogs.FlatWelcomeFrame; | ||
import com.redhat.devtools.intellij.commonuitest.fixtures.mainidewindow.idestatusbar.IdeStatusBar; | ||
import com.redhat.devtools.intellij.commonuitest.fixtures.mainidewindow.toolwindowspane.ToolWindowPane; | ||
import com.redhat.devtools.intellij.commonuitest.utils.project.CreateCloseUtils; | ||
import com.redhat.devtools.intellij.commonuitest.utils.screenshot.ScreenshotUtils; | ||
import org.jboss.tools.intellij.openshift.test.ui.annotations.UITest; | ||
|
@@ -37,7 +35,6 @@ | |
import java.io.File; | ||
import java.time.Duration; | ||
|
||
|
||
/** | ||
* @author Ondrej Dockal, [email protected] | ||
*/ | ||
|
@@ -110,20 +107,6 @@ protected static void logOut() { | |
} | ||
} | ||
|
||
public RemoteRobot getRobotReference() { | ||
return robot; | ||
} | ||
|
||
public boolean isStripeButtonAvailable(String label) { | ||
try { | ||
ToolWindowPane toolWindowPane = robot.find(ToolWindowPane.class); | ||
toolWindowPane.stripeButton(label, false); | ||
} catch (WaitForConditionTimeoutException e) { | ||
return false; | ||
} | ||
return true; | ||
} | ||
|
||
protected static void sleep(long ms) { | ||
LOGGER.info("Putting thread into sleep for: {} ms", ms); | ||
try { | ||
|
16 changes: 15 additions & 1 deletion
16
src/it/java/org/jboss/tools/intellij/openshift/test/ui/ClusterTestsSuite.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 15 additions & 1 deletion
16
src/it/java/org/jboss/tools/intellij/openshift/test/ui/PublicTestsSuite.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 0 additions & 41 deletions
41
src/it/java/org/jboss/tools/intellij/openshift/test/ui/common/CreateComponentFixture.java
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
...jboss/tools/intellij/openshift/test/ui/common/ImportProjectFromVersionControlFixture.java
This file was deleted.
Oops, something went wrong.
47 changes: 0 additions & 47 deletions
47
src/it/java/org/jboss/tools/intellij/openshift/test/ui/common/ProjectTreeFixture.java
This file was deleted.
Oops, something went wrong.
38 changes: 0 additions & 38 deletions
38
src/it/java/org/jboss/tools/intellij/openshift/test/ui/common/WelcomeDialogFixture.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I get it right that these creates are not needed any more because you disabled the service tests?
Wouldn't it be preferrable to comment these since the tests also still exist but are disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah iagree to comment out because the test is disabled and not removed.