add dotnet template #60
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,298 @@ | ||
| { | ||
| "kind": "Template", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "dotnet", | ||
|
|
||
| "annotations": { | ||
| "openshift.io/display-name": ".NET Core", | ||
| "description": "Template for creating .NET Core service", | ||
|
There was a problem hiding this comment. update to: "An example .NET Core application" |
||
| "tags": "quickstart,dotnet,.net", | ||
| "iconClass": "icon-dotnet", | ||
| "template.openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "template.openshift.io/documentation-url": "https://github.com/redhat-developer/s2i-dotnetcore", | ||
| "template.openshift.io/support-url": "https://access.redhat.com" | ||
| } | ||
| }, | ||
| "objects": [ | ||
| { | ||
| "kind": "Service", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "${NAME}", | ||
| "annotations": { | ||
| "description": "Exposes and load balances the application pods" | ||
| } | ||
| }, | ||
| "spec": { | ||
| "ports": [ | ||
| { | ||
| "name": "web", | ||
| "port": 8080, | ||
| "targetPort": 8080 | ||
| } | ||
| ], | ||
| "selector": { | ||
| "name": "${NAME}" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "kind": "ImageStream", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "${NAME}", | ||
| "annotations": { | ||
| "description": "Keeps track of changes in the application image" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "kind": "BuildConfig", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "${NAME}", | ||
| "annotations": { | ||
| "description": "Defines how to build the application" | ||
| } | ||
| }, | ||
| "spec": { | ||
| "source": { | ||
| "type": "Git", | ||
| "git": { | ||
| "uri": "${SOURCE_REPOSITORY_URL}", | ||
| "ref": "${SOURCE_REPOSITORY_REF}" | ||
| }, | ||
| "contextDir": "${CONTEXT_DIR}" | ||
| }, | ||
| "strategy": { | ||
| "type": "Source", | ||
| "sourceStrategy": { | ||
| "from": { | ||
| "kind": "ImageStreamTag", | ||
| "namespace": "${NAMESPACE}", | ||
| "name": "${DOTNET_IMAGE_STREAM_TAG}" | ||
| }, | ||
| "env": [ | ||
| { | ||
| "name": "DOTNET_STARTUP_PROJECT", | ||
| "value": "${DOTNET_STARTUP_PROJECT}" | ||
| }, | ||
| { | ||
| "name": "DOTNET_ASSEMBLY_NAME", | ||
| "value": "${DOTNET_ASSEMBLY_NAME}" | ||
| }, | ||
| { | ||
| "name": "DOTNET_NPM_TOOLS", | ||
| "value": "${DOTNET_NPM_TOOLS}" | ||
| }, | ||
| { | ||
| "name": "DOTNET_TEST_PROJECTS", | ||
| "value": "${DOTNET_TEST_PROJECTS}" | ||
| }, | ||
| { | ||
| "name": "DOTNET_CONFIGURATION", | ||
| "value": "${DOTNET_CONFIGURATION}" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "output": { | ||
| "to": { | ||
| "kind": "ImageStreamTag", | ||
| "name": "${NAME}:latest" | ||
| } | ||
| }, | ||
| "triggers": [ | ||
| { | ||
| "type": "ImageChange" | ||
| }, | ||
| { | ||
| "type": "ConfigChange" | ||
| }, | ||
| { | ||
| "type": "GitHub", | ||
| "github": { | ||
| "secret": "${GITHUB_WEBHOOK_SECRET}" | ||
| } | ||
| }, | ||
| { | ||
| "type": "Generic", | ||
| "generic": { | ||
| "secret": "${GENERIC_WEBHOOK_SECRET}" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "kind": "DeploymentConfig", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "${NAME}", | ||
| "annotations": { | ||
| "description": "Defines how to deploy the application server" | ||
| } | ||
| }, | ||
| "spec": { | ||
| "strategy": { | ||
| "type": "Rolling" | ||
| }, | ||
| "triggers": [ | ||
| { | ||
| "type": "ImageChange", | ||
| "imageChangeParams": { | ||
| "automatic": true, | ||
| "containerNames": [ | ||
| "dotnet-app" | ||
| ], | ||
| "from": { | ||
| "kind": "ImageStreamTag", | ||
| "name": "${NAME}:latest" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "ConfigChange" | ||
| } | ||
| ], | ||
| "replicas": 1, | ||
| "selector": { | ||
| "name": "${NAME}" | ||
| }, | ||
| "template": { | ||
| "metadata": { | ||
| "name": "${NAME}", | ||
| "labels": { | ||
| "name": "${NAME}" | ||
| } | ||
| }, | ||
| "spec": { | ||
| "containers": [ | ||
| { | ||
| "name": "dotnet-app", | ||
| "image": " ", | ||
| "ports": [ | ||
| { | ||
| "containerPort": 8080 | ||
| } | ||
| ], | ||
| "livenessProbe": { | ||
| "httpGet": { | ||
| "path": "/", | ||
| "port": 8080, | ||
| "scheme": "HTTP" | ||
| }, | ||
| "initialDelaySeconds": 40, | ||
| "timeoutSeconds": 10 | ||
| }, | ||
| "readinessProbe": { | ||
| "httpGet": { | ||
| "path": "/", | ||
| "port": 8080, | ||
| "scheme": "HTTP" | ||
| }, | ||
| "initialDelaySeconds": 10, | ||
| "timeoutSeconds": 30 | ||
| }, | ||
| "resources": { | ||
| "limits": { | ||
| "memory": "${MEMORY_LIMIT}" | ||
| } | ||
| }, | ||
| "env": [] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "parameters": [ | ||
| { | ||
| "name": "NAME", | ||
| "displayName": "Name", | ||
| "description": "The name assigned to all of the frontend objects defined in this template.", | ||
| "required": true, | ||
| "value": "dotnet-service" | ||
| }, | ||
|
|
||
| { | ||
| "name": "MEMORY_LIMIT", | ||
| "displayName": "Memory Limit", | ||
| "description": "Maximum amount of memory the container can use.", | ||
| "required": true, | ||
| "value": "512Mi" | ||
| }, | ||
| { | ||
| "name": "DOTNET_IMAGE_STREAM_TAG", | ||
| "displayName": ".NET builder", | ||
| "required": true, | ||
| "description": "The image stream tag which is used to build the code.", | ||
| "value": "dotnet:1.0" | ||
| }, | ||
| { | ||
| "name": "NAMESPACE", | ||
| "displayName": "Namespace", | ||
| "description": "The OpenShift Namespace where the ImageStream resides.", | ||
| "required": true, | ||
| "value": "openshift" | ||
| }, | ||
| { | ||
| "name": "SOURCE_REPOSITORY_URL", | ||
| "displayName": "Git Repository URL", | ||
| "description": "The URL of the repository with your application source code.", | ||
| "required": true, | ||
| "value": "https://github.com/redhat-developer/s2i-dotnetcore-ex.git" | ||
| }, | ||
| { | ||
| "name": "SOURCE_REPOSITORY_REF", | ||
| "displayName": "Git Reference", | ||
| "description": "Set this to a branch name, tag or other ref of your repository if you are not using the default branch." | ||
|
There was a problem hiding this comment. This should perhaps default to "dotnetcore-1.0". That would match "dotnet:1.0" as the default builder image. |
||
| }, | ||
| { | ||
| "name": "CONTEXT_DIR", | ||
| "displayName": "Context Directory", | ||
| "description": "Set this to the relative path to your project if it is not in the root of your repository." | ||
|
There was a problem hiding this comment. "Set this to use a subdirectory of the source code repository" There was a problem hiding this comment. We should set this to "app" since that would allow one to instantiate the template with all the defaults, and it would build and run. s2i-dotnetcore-ex app sources are in "app" There was a problem hiding this comment. I have a preference for setting DOTNET_STARTUP_PROJECT to demonstrate that parameter. I'd do the same for the dotnet+postgre template, if it wasn't for the big restore time of one of the projects we are not using. The postgre template can be update when we support msbuild. There was a problem hiding this comment. OK, makes sense. I missed that. |
||
| }, | ||
| { | ||
| "name": "GITHUB_WEBHOOK_SECRET", | ||
| "displayName": "GitHub Webhook Secret", | ||
| "description": "A secret string used to configure the GitHub webhook.", | ||
| "generate": "expression", | ||
| "from": "[a-zA-Z0-9]{40}" | ||
| }, | ||
| { | ||
| "name": "GENERIC_WEBHOOK_SECRET", | ||
| "displayName": "Generic Webhook Secret", | ||
| "description": "A secret string used to configure the Generic webhook.", | ||
| "generate": "expression", | ||
| "from": "[a-zA-Z0-9]{40}" | ||
| }, | ||
| { | ||
| "name": "DOTNET_STARTUP_PROJECT", | ||
| "displayName": "Startup Project", | ||
| "description": "Set this to the folder containing your startup project.", | ||
| "value": "app" | ||
| }, | ||
| { | ||
| "name": "DOTNET_ASSEMBLY_NAME", | ||
| "displayName": "Startup Assembly", | ||
| "description": "Set this when the assembly name is overridden in the project file." | ||
| }, | ||
| { | ||
| "name": "DOTNET_NPM_TOOLS", | ||
| "displayName": "Npm Tools", | ||
| "description": "Set this to a space separated list of npm tools needed to publish." | ||
| }, | ||
| { | ||
| "name": "DOTNET_TEST_PROJECTS", | ||
| "displayName": "Test projects", | ||
| "description": "Set this to a space separated list of test projects to run before publishing." | ||
| }, | ||
| { | ||
| "name": "DOTNET_CONFIGURATION", | ||
| "displayName": "Configuration", | ||
| "description": "Set this to configuration (Release/Debug).", | ||
| "value": "Release" | ||
| } | ||
| ] | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dotnet-example", & update json filename