add dotnet template #60
Conversation
The dotnet template can be used to create a new .NET Core service in OpenShift. It provides parameters for all the environment variables of the s2i-dotnetcore builder. It also includes a liveness and a readiness probe.
|
This is implementing #56 |
templates/dotnet.json
Outdated
| "kind": "Template", | ||
| "apiVersion": "v1", | ||
| "metadata": { | ||
| "name": "dotnet", |
templates/dotnet.json
Outdated
| "name": "dotnet", | ||
| "annotations": { | ||
| "openshift.io/display-name": ".NET Core", | ||
| "description": "Template for creating .NET Core service", |
There was a problem hiding this comment.
update to: "An example .NET Core application"
templates/dotnet.json
Outdated
| "description": "The name assigned to all of the frontend objects defined in this template.", | ||
| "required": true, | ||
| "value": "dotnet-service" | ||
| }, |
README.md
Outdated
| oc create -f <template.json> | ||
| ``` | ||
|
|
||
| **dotnet** |
There was a problem hiding this comment.
"dotnet-example", & update json filename
README.md
Outdated
|
|
||
| **dotnet** | ||
|
|
||
| The dotnet template can be used to create a new .NET Core service in OpenShift. It provides parameters for all the environment |
templates/dotnet.json
Outdated
| { | ||
| "name": "CONTEXT_DIR", | ||
| "displayName": "Context Directory", | ||
| "description": "Set this to the relative path to your project if it is not in the root of your repository." |
There was a problem hiding this comment.
"Set this to use a subdirectory of the source code repository"
There was a problem hiding this comment.
We should set this to "app" since that would allow one to instantiate the template with all the defaults, and it would build and run. s2i-dotnetcore-ex app sources are in "app"
There was a problem hiding this comment.
I have a preference for setting DOTNET_STARTUP_PROJECT to demonstrate that parameter. I'd do the same for the dotnet+postgre template, if it wasn't for the big restore time of one of the projects we are not using. The postgre template can be update when we support msbuild.
There was a problem hiding this comment.
OK, makes sense. I missed that.
templates/dotnet.json
Outdated
| { | ||
| "name": "SOURCE_REPOSITORY_REF", | ||
| "displayName": "Git Reference", | ||
| "description": "Set this to a branch name, tag or other ref of your repository if you are not using the default branch." |
There was a problem hiding this comment.
This should perhaps default to "dotnetcore-1.0". That would match "dotnet:1.0" as the default builder image.
tmds
force-pushed
the
feature/dotnet-template
branch
from
b9e7046 to
780b1f2
Compare
templates/dotnet-example.json
Outdated
| { | ||
| "name": "APPLICATION_DOMAIN", | ||
| "displayName": "Application Hostname", | ||
| "description": "The exposed hostname that will route to the Node.js service, if left blank a value will be defaulted.", |
There was a problem hiding this comment.
I believe you don't want to reference Node.js do you?
templates/dotnet-example.json
Outdated
| }, | ||
| { | ||
| "name": "DOTNET_PUBLISH", | ||
| "value": "Y" |
The dotnet template can be used to create a new .NET Core service in OpenShift.
It provides parameters for all the environment variables of the s2i-dotnetcore
builder. It also includes a liveness and a readiness probe.