test: upgrade redis version(7.0.7) #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monkey92t <[email protected]>
SoulPancake
reviewed
Apr 3, 2023
| @@ -18,7 +18,7 @@ bench: testdeps | |||
|
|
|||
| testdata/redis: | |||
| mkdir -p $@ | |||
| wget -qO- https://download.redis.io/releases/redis-7.0.6.tar.gz | tar xvz --strip-components=1 -C $@ | |||
| wget -qO- https://download.redis.io/releases/redis-7.0.7.tar.gz | tar xvz --strip-components=1 -C $@ | |||
There was a problem hiding this comment.
Do we need to update the testdata version by this?
For Redis 7.2 commands support? @monkey92t
There was a problem hiding this comment.
So, for the tests to pass can I raise a PR that does this?
There was a problem hiding this comment.
I've created a PR but something seems to have changed in 7.2, I'm looking at the redis-server code and need some time to fix it
There was a problem hiding this comment.
There are already issues for the two commands whose tests would fail with the new versions
Can I raise PRs for those?
There was a problem hiding this comment.
Referring to #2526 and #2525 @monkey92t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.