Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: redis-version to 7.2-rc1 #2532

Merged
merged 4 commits into from
Apr 12, 2023
Merged

test: redis-version to 7.2-rc1 #2532

merged 4 commits into from
Apr 12, 2023

Conversation

monkey92t
Copy link
Collaborator

No description provided.

@SoulPancake
Copy link
Contributor

Should we raise the updated versions ( 7.2 compatible versions of XINFO Consumers and XINFO streams ) and then upgrade the redis server? @monkey92t
I can quickly raise the PRs for those and update the tests

@monkey92t monkey92t mentioned this pull request Apr 3, 2023
Merged
monkey92t added 2 commits April 3, 2023 23:23
@monkey92t
follow up redis-7.2
a0fb1fe 
Signed-off-by: monkey92t <[email protected]>
@monkey92t
correction test
c34cc77 
Signed-off-by: monkey92t <[email protected]>
@monkey92t
Copy link
Collaborator Author

monkey92t commented Apr 3, 2023 •
edited
Loading

In the redis:latest image, the ENV REDIS_VERSION=7.0.10 version is used.

I corrected the image-version: redis:7.2-rc

SoulPancake
SoulPancake approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@SoulPancake SoulPancake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoulPancake
Copy link
Contributor

Can we merge this? @monkey92t For proceeding with the other PRs for version 7.2

@SoulPancake
Copy link
Contributor

Any updates on this ? @monkey92t

@monkey92t monkey92t requested review from vmihailenco and chayim April 11, 2023 02:46
@monkey92t monkey92t merged commit 6edb152 into redis:master Apr 12, 2023
@monkey92t monkey92t deleted the update_redis_server branch April 12, 2023 12:17
@monkey92t monkey92t mentioned this pull request Apr 12, 2023
Closed
@SoulPancake SoulPancake mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmihailenco vmihailenco vmihailenco approved these changes

@SoulPancake SoulPancake SoulPancake approved these changes

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monkey92t @SoulPancake @vmihailenco