Skip to content

docs: Remove misplaced npm install #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2022
Merged

docs: Remove misplaced npm install #8811

merged 3 commits into from
Apr 24, 2022

Conversation

tkindy
Copy link
Contributor

@tkindy tkindy commented Apr 23, 2022

I think this line was originally meant to be in the "Install React Router v6" section, but there's already an npm install command shown there.

I think this line was originally meant to be in the "Install React Router v6" call, but there's already an `npm install` command shown there.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 23, 2022

Hi @tkindy,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@tkindy
Copy link
Contributor Author

tkindy commented Apr 23, 2022

Or maybe this line I deleted should replace the npm install react-router@next that's in the "Install React Router v6" section? That one doesn't include react-router-dom which seems like a mistake.

@timdorr
Copy link
Member

timdorr commented Apr 24, 2022

I got you on that. Thanks!

@timdorr timdorr merged commit 6290356 into remix-run:main Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants