Skip to content

docs: Remove misplaced npm install #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- thisiskartik
- ThornWu
- timdorr
- tkindy
- turansky
- underager
- vijaypushkin
6 changes: 1 addition & 5 deletions docs/upgrading/reach.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,6 @@ Not polluting props also helps with TypeScript a bit and also prevents you from

Also, as a page grows, you naturally break it into multiple components and end up "prop drilling" that data all the way down the tree. Now you can access the route data anywhere in the tree. Not only is it more convenient, but it makes creating router-centric composable abstractions possible. If a custom hook needs the location, it can now simply ask for it with `useLocation()` etc..

```sh
npm install react-router@6 react-router-dom@6
```

### Add a LocationProvider

While `@reach/router` doesn't require a location provider at the top of the application tree, React Router v6 does, so might as well get ready for that now.
Expand Down Expand Up @@ -163,7 +159,7 @@ You can pull a trick though and use both routers at the same time as you migrate
### Install React Router v6

```sh
npm install react-router@next
npm install react-router@6 react-router-dom@6
```

### Update `LocationProvider` to `BrowserRouter`
Expand Down