Skip to content

remove model.predict() #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

remove model.predict() #71

merged 1 commit into from
Feb 20, 2023

Conversation

zeke
Copy link
Member

@zeke zeke commented Feb 20, 2023

This PR removes the model.predict() method. If someone tries to call it they'll get an exception.

Normally it would make sense to deprecate stuff like this, but maybe since it's early days we can just break it.

This would be a great time to start using Semantic Versioning. We could call this 1.0.0, since it's a breaking change.

Resolves #69

Signed-off-by: Zeke Sikelianos <[email protected]>
@zeke zeke requested review from erbridge and mattt February 20, 2023 21:32
Copy link
Member

@erbridge erbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'd suggest we can treat 0.x bumps as "major" until we hit 1.x, though, so don't need to bump up to "stable" just for this.

@bfirsh
Copy link
Member

bfirsh commented Feb 20, 2023

👍 Perhaps we wait until we have a JS client that matches the Python client then we could increment them to 1.0 at the same time and keep them more-or-less in line with each other.

@zeke zeke merged commit 6a7739b into main Feb 20, 2023
@zeke zeke deleted the remove-model-predict-method branch February 20, 2023 22:11
@zeke
Copy link
Member Author

zeke commented Feb 20, 2023

🚢 https://github.com/replicate/replicate-python/releases/tag/0.5.0

Here's how I did it:

$ git commit -am "bump version to 0.5.0"
[main f71eec6] bump version to 0.5.0
 1 file changed, 1 insertion(+), 1 deletion(-)


$ git checkout main
Already on 'main'
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)


$ git checkout main
Already on 'main'
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)


$ git tag 0.5.0


$ git push --tags
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 368 bytes | 368.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To https://github.com/replicate/replicate-python
 * [new tag]         0.5.0 -> 0.5.0

GothReigen added a commit that referenced this pull request Jan 3, 2024
Context: 

> Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79.

#137

Trying the example in the current iteration of `replicate/replicate-python` would return the following exception:

```python
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict'
```
GothReigen added a commit that referenced this pull request Jan 3, 2024
Context:

> Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79.

#137

Trying the example in the current iteration of `replicate/replicate-python` would return the following exception:

```python
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict'
```

Signed-off-by: Michael Lee <[email protected]>
zeke pushed a commit that referenced this pull request Jan 4, 2024
Context:

> Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79.

#137

Trying the example in the current iteration of `replicate/replicate-python` would return the following exception:

```python
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict'
```

Signed-off-by: Michael Lee <[email protected]>
GothReigen added a commit that referenced this pull request Feb 9, 2024
Context:

> Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79.

#137

Trying the example in the current iteration of `replicate/replicate-python` would return the following exception:

```python
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict'
```

Signed-off-by: GothReigen <[email protected]>
GothReigen added a commit that referenced this pull request Mar 11, 2024
Context:

> Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79.

#137

Trying the example in the current iteration of `replicate/replicate-python` would return the following exception:

```python
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict'
```

Signed-off-by: GothReigen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it hard to not pin a version
3 participants