-
Notifications
You must be signed in to change notification settings - Fork 245
remove model.predict() #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zeke Sikelianos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. I'd suggest we can treat 0.x
bumps as "major" until we hit 1.x
, though, so don't need to bump up to "stable" just for this.
👍 Perhaps we wait until we have a JS client that matches the Python client then we could increment them to 1.0 at the same time and keep them more-or-less in line with each other. |
🚢 https://github.com/replicate/replicate-python/releases/tag/0.5.0 Here's how I did it:
|
Context: > Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79. #137 Trying the example in the current iteration of `replicate/replicate-python` would return the following exception: ```python discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict' ```
Context: > Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79. #137 Trying the example in the current iteration of `replicate/replicate-python` would return the following exception: ```python discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict' ``` Signed-off-by: Michael Lee <[email protected]>
Context: > Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79. #137 Trying the example in the current iteration of `replicate/replicate-python` would return the following exception: ```python discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict' ``` Signed-off-by: Michael Lee <[email protected]>
Context: > Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79. #137 Trying the example in the current iteration of `replicate/replicate-python` would return the following exception: ```python discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict' ``` Signed-off-by: GothReigen <[email protected]>
Context: > Model.predict was removed in #71. It points users to Version.predict, but that method was deprecated in favor of replicate.run in #79. #137 Trying the example in the current iteration of `replicate/replicate-python` would return the following exception: ```python discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Version' object has no attribute 'predict' ``` Signed-off-by: GothReigen <[email protected]>
This PR removes the
model.predict()
method. If someone tries to call it they'll get an exception.Normally it would make sense to deprecate stuff like this, but maybe since it's early days we can just break it.
This would be a great time to start using Semantic Versioning. We could call this 1.0.0, since it's a breaking change.
Resolves #69