Skip to content

remove model.predict() #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions replicate/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@ class Model(BaseModel):
name: str

def predict(self, *args, **kwargs):
versions = self.versions.list()
if not versions:
raise ReplicateException(
"No versions found for model %s/%s" % (self.username, self.name)
)
latest_version = versions[0]
return latest_version.predict(*args, **kwargs)
raise ReplicateException(
f"The `model.predict()` method has been removed, because it's unstable: if a new version of the model you're using is pushed and its API has changed, your code may break. Use `version.predict()` instead. See https://github.com/replicate/replicate-python#readme"
)

@property
def versions(self):
Expand Down