Code

Explore type based autocomplete#493

Code

Closed

zth wants to merge 81 commits intomasterrescript-lang/rescript-vscode:masterfrom

type-based-autocompleterescript-lang/rescript-vscode:type-based-autocompleteCopy head branch name to clipboard

Commits

Commits on Jul 14, 2022

• add base test case for completing jsx prop and labelled argument

  zth

  committed
  7db9012

  Copy full SHA for 7db9012

• commit the rest of the updated test result files

  zth

  committed
  4362bdf

  Copy full SHA for 4362bdf

• fix accidentally broken completion example

  zth

  committed
  87508b3

  Copy full SHA for 87508b3

Commits on Jul 15, 2022

• identify typed context for labelled argument assignments

  zth

  committed
  5ed8bb4

  Copy full SHA for 5ed8bb4

Commits on Jul 16, 2022

• remove special handling of equality char

  zth

  committed
  d121e73

  Copy full SHA for d121e73

• use trick from JSX prop completion to identify empty assignment of labelled argument

  zth

  committed
  57e7cce

  Copy full SHA for 57e7cce

Commits on Jul 17, 2022

• crude implementation of completing variant constructors

  zth

  committed
  b125207

  Copy full SHA for b125207

• rename and specialize test file so that it will only contain tests for labelled argument completion

  zth

  committed
  431ab48

  Copy full SHA for 431ab48

• generalize completion so it theoretically can handle more than variants

  zth

  committed
  bdd2e11

  Copy full SHA for bdd2e11

• add assigned identifier to test file

  zth

  committed
  bea78fe

  Copy full SHA for bea78fe

• add more args to test function in test file

  zth

  committed
  5ebe602

  Copy full SHA for 5ebe602

• filter completed variant constructors on what the user has already written

  zth

  committed
  b85c4ae

  Copy full SHA for b85c4ae

• add example completing variant from other file

  zth

  committed
  dd8333e

  Copy full SHA for dd8333e

• complete polyvariants in addition to regular variants

  zth

  committed
  ffa06f4

  Copy full SHA for ffa06f4

Commits on Jul 18, 2022

• clarifications and touch ups after pr comments

  zth

  committed
  37e4f9b

  Copy full SHA for 37e4f9b

• add dedicated example file for JSX completions

  zth

  committed
  c2e2adf

  Copy full SHA for c2e2adf

• inline contextPath into NamedArg to pave way for JsxProp, that will not explicitly need the contextPAth

  zth

  committed
  d1d86e8

  Copy full SHA for d1d86e8

Commits on Jul 19, 2022

• add jsx example completing across files

  zth

  committed
  90ccf19

  Copy full SHA for 90ccf19

Commits on Jul 25, 2022

• basic JSX prop completion via type

  zth

  committed
  d54b562

  Copy full SHA for d54b562

• add completions from context in addition to the explicit type based completions

  zth

  committed
  2b29291

  Copy full SHA for 2b29291

• bring contextual completions to labelled arguments as well

  zth

  committed
  27532b0

  Copy full SHA for 27532b0

• remove redundant comment#

  zth

  committed
  e87ad5a

  Copy full SHA for e87ad5a

• Merge branch 'master' into type-based-autocomplete

  zth

  committed
  f79a38d

  Copy full SHA for f79a38d

Commits on Jul 27, 2022

• take a step back and remove typed completions for now. focus on identifying the correct typed contexts first

  zth

  committed
  b260d38

  Copy full SHA for b260d38

Commits on Jul 30, 2022

• add some completion cases for records

  zth

  committed
  54e596c

  Copy full SHA for 54e596c

• refactor to continuously setting the typed context we're currently looking for

  zth

  committed
  8c49fa5

  Copy full SHA for 8c49fa5

• fix + debug util

  zth

  committed
  c8f112a

  Copy full SHA for c8f112a

• identify and complete for record fields when destructuring

  zth

  committed
  49e45d8

  Copy full SHA for 49e45d8

• allow any expr, which makes fn returns also work

  zth

  committed
  7c8a1ad

  Copy full SHA for 7c8a1ad

Commits on Jul 31, 2022

• basic, slightly buggy completion for nested record fields

  zth

  committed
  b34c35d

  Copy full SHA for b34c35d

Commits on Aug 1, 2022

• do not complete if we cant find the cursor inside of nested pattern

  zth

  committed
  7b1b8cd

  Copy full SHA for 7b1b8cd

• add more broken test cases

  zth

  committed
  f79f21b

  Copy full SHA for f79f21b

• ensure completing from empty root records work as expected

  zth

  committed
  0df2b0c

  Copy full SHA for 0df2b0c

• look for ',' as first char before cursor to trigger completion in cases where the parser discards things we'd need to trigger completion

  zth

  committed
  33cd645

  Copy full SHA for 33cd645

• refactor

  zth

  committed
  f21a06e

  Copy full SHA for f21a06e

Commits on Aug 2, 2022

• refactor completion to use new way of recursively digging to the target type

  zth

  committed
  44698e4

  Copy full SHA for 44698e4

• start refactoring the typed context

  zth

  committed
  48b7bec

  Copy full SHA for 48b7bec

• add another label to the record so we can test prefix etc in a better way

  zth

  committed
  295be6b

  Copy full SHA for 295be6b

• bring back prefix and seen record fields filtering for destructuring records

  zth

  committed
  5a2097e

  Copy full SHA for 5a2097e

• change test message some

  zth

  committed
  da23ca8

  Copy full SHA for da23ca8

Commits on Aug 4, 2022

• more completion exploration

  zth

  committed
  39a35ec

  Copy full SHA for 39a35ec

• cleanup and comments on where I'm at right now

  zth

  committed
  f9515d1

  Copy full SHA for f9515d1

Commits on Aug 9, 2022

• narrow the places where type based completion is invoked

  zth

  committed
  a268d24

  Copy full SHA for a268d24

• complete record field destructuring in switch patterns

  zth

  committed
  9f511cd

  Copy full SHA for 9f511cd

• comment

  zth

  committed
  ef427d2

  Copy full SHA for ef427d2

Commits on Aug 10, 2022

• wip

  zth

  committed
  555110f

  Copy full SHA for 555110f

• more work on nested completion in patterns

  zth

  committed
  cf8b472

  Copy full SHA for cf8b472

Commits on Aug 11, 2022

• pick up already seen idents for constructors/record fields

  zth

  committed
  3a6a6e5

  Copy full SHA for 3a6a6e5

• basic completion of options

  zth

  committed
  339417c

  Copy full SHA for 339417c

• complete empty | patterns

  zth

  committed
  928e84e

  Copy full SHA for 928e84e

• fix only descending to record field if valid

  zth

  committed
  d134b8b

  Copy full SHA for d134b8b

• more filtering of idents

  zth

  committed
  0d06fc6

  Copy full SHA for 0d06fc6

• fix record completion of empty ,

  zth

  committed
  d2ef230

  Copy full SHA for d2ef230

• temp disable local completions + constructor completions in general scope, to make testing a bit easier/reduce false positives

  zth

  committed
  013680e

  Copy full SHA for 013680e

• commit test output from last commit

  zth

  committed
  303eb57

  Copy full SHA for 303eb57

• handle completing empty patterns in records

  zth

  committed
  858be8f

  Copy full SHA for 858be8f

• complete booleans

  zth

  committed
  d5ced33

  Copy full SHA for d5ced33

Commits on Aug 13, 2022

• more work, plugging holes etc

  zth

  committed
  1679769

  Copy full SHA for 1679769

• complete patterns in arguments of fns passed to named arguments

  zth

  committed
  f262a50

  Copy full SHA for f262a50

Commits on Aug 14, 2022

• rename

  zth

  committed
  28dddca

  Copy full SHA for 28dddca

Commits on Aug 15, 2022

• add debug tool and start setting up spec for typed context completion

  zth

  committed
  8a98793

  Copy full SHA for 8a98793

• start moving to rewrite of finding pattern completable

  zth

  committed
  5647a1e

  Copy full SHA for 5647a1e

Commits on Aug 16, 2022

• hook up completion backend with new pattern completion stuff

  zth

  committed
  2c1b721

  Copy full SHA for 2c1b721

• complete clean up of the old way of doing pattern completion

  zth

  committed
  5d69adb

  Copy full SHA for 5d69adb

• simplify

  zth

  committed
  f061119

  Copy full SHA for f061119

• complete empty tuples

  zth

  committed
  82796f9

  Copy full SHA for 82796f9

• introduce snippets

  zth

  committed
  6a0a884

  Copy full SHA for 6a0a884

• properly apply command

  zth

  committed
  f98db04

  Copy full SHA for f98db04

• implement support for tuple context paths in completion

  zth

  committed
  5558995

  Copy full SHA for 5558995

• dump pexp_field

  zth

  committed
  5320d9e

  Copy full SHA for 5320d9e

Commits on Aug 17, 2022

• add typed expression completion type

  zth

  committed
  36832cc

  Copy full SHA for 36832cc

• some cleanup and other fixes

  zth

  committed
  eb3eb80

  Copy full SHA for eb3eb80

• track seen record fields when constructing a record

  zth

  committed
  859c3fd

  Copy full SHA for 859c3fd

Commits on Aug 18, 2022

• add a few test fixtures where the parser doesnt do quite what I need it to

  zth

  committed
  e67f63c

  Copy full SHA for e67f63c

Commits on Aug 20, 2022

• another broken case

  zth

  committed
  64f4f77

  Copy full SHA for 64f4f77

• support completing expressions when assigning variables, even if the expression strictly does not compile (but the compiler understands what type it will be eventually

  zth

  committed
  40e3ec1

  Copy full SHA for 40e3ec1

• pull put var from constraint pattern for now

  zth

  committed
  e330b68

  Copy full SHA for e330b68

• more cases

  zth

  committed
  fc48ca8

  Copy full SHA for fc48ca8

Commits on Sep 2, 2022

• make sure the newest env is always propagated

  zth

  committed
  cd2161a

  Copy full SHA for cd2161a

Commits on Sep 7, 2022

• fix issue where Some variants wouldnt be handled properly

  zth

  committed
  0522d01

  Copy full SHA for 0522d01

• complete inline records

  zth

  committed
  16a6f0f

  Copy full SHA for 16a6f0f