-
Notifications
You must be signed in to change notification settings - Fork 59
Explore type based autocomplete #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
7db9012
add base test case for completing jsx prop and labelled argument
zth 4362bdf
commit the rest of the updated test result files
zth 87508b3
fix accidentally broken completion example
zth 5ed8bb4
identify typed context for labelled argument assignments
zth d121e73
remove special handling of equality char
zth 57e7cce
use trick from JSX prop completion to identify empty assignment of la…
zth b125207
crude implementation of completing variant constructors
zth 431ab48
rename and specialize test file so that it will only contain tests fo…
zth bdd2e11
generalize completion so it theoretically can handle more than variants
zth bea78fe
add assigned identifier to test file
zth 5ebe602
add more args to test function in test file
zth b85c4ae
filter completed variant constructors on what the user has already wr…
zth dd8333e
add example completing variant from other file
zth ffa06f4
complete polyvariants in addition to regular variants
zth 37e4f9b
clarifications and touch ups after pr comments
zth c2e2adf
add dedicated example file for JSX completions
zth d1d86e8
inline contextPath into NamedArg to pave way for JsxProp, that will n…
zth 90ccf19
add jsx example completing across files
zth d54b562
basic JSX prop completion via type
zth 2b29291
add completions from context in addition to the explicit type based c…
zth 27532b0
bring contextual completions to labelled arguments as well
zth e87ad5a
remove redundant comment#
zth f79a38d
Merge branch 'master' into type-based-autocomplete
zth b260d38
take a step back and remove typed completions for now. focus on ident…
zth 54e596c
add some completion cases for records
zth 8c49fa5
refactor to continuously setting the typed context we're currently lo…
zth c8f112a
fix + debug util
zth 49e45d8
identify and complete for record fields when destructuring
zth 7c8a1ad
allow any expr, which makes fn returns also work
zth b34c35d
basic, slightly buggy completion for nested record fields
zth 7b1b8cd
do not complete if we cant find the cursor inside of nested pattern
zth f79f21b
add more broken test cases
zth 0df2b0c
ensure completing from empty root records work as expected
zth 33cd645
look for ',' as first char before cursor to trigger completion in cas…
zth f21a06e
refactor
zth 44698e4
refactor completion to use new way of recursively digging to the targ…
zth 48b7bec
start refactoring the typed context
zth 295be6b
add another label to the record so we can test prefix etc in a better…
zth 5a2097e
bring back prefix and seen record fields filtering for destructuring …
zth da23ca8
change test message some
zth 39a35ec
more completion exploration
zth f9515d1
cleanup and comments on where I'm at right now
zth a268d24
narrow the places where type based completion is invoked
zth 9f511cd
complete record field destructuring in switch patterns
zth ef427d2
comment
zth 555110f
wip
zth cf8b472
more work on nested completion in patterns
zth 3a6a6e5
pick up already seen idents for constructors/record fields
zth 339417c
basic completion of options
zth 928e84e
complete empty | patterns
zth d134b8b
fix only descending to record field if valid
zth 0d06fc6
more filtering of idents
zth d2ef230
fix record completion of empty ,
zth 013680e
temp disable local completions + constructor completions in general s…
zth 303eb57
commit test output from last commit
zth 858be8f
handle completing empty patterns in records
zth d5ced33
complete booleans
zth 1679769
more work, plugging holes etc
zth f262a50
complete patterns in arguments of fns passed to named arguments
zth 28dddca
rename
zth 8a98793
add debug tool and start setting up spec for typed context completion
zth 5647a1e
start moving to rewrite of finding pattern completable
zth 2c1b721
hook up completion backend with new pattern completion stuff
zth 5d69adb
complete clean up of the old way of doing pattern completion
zth f061119
simplify
zth 82796f9
complete empty tuples
zth 6a0a884
introduce snippets
zth f98db04
properly apply command
zth 5558995
implement support for tuple context paths in completion
zth 5320d9e
dump pexp_field
zth 36832cc
add typed expression completion type
zth eb3eb80
some cleanup and other fixes
zth 859c3fd
track seen record fields when constructing a record
zth e67f63c
add a few test fixtures where the parser doesnt do quite what I need …
zth 64f4f77
another broken case
zth 40e3ec1
support completing expressions when assigning variables, even if the …
zth e330b68
pull put var from constraint pattern for now
zth fc48ca8
more cases
zth cd2161a
make sure the newest env is always propagated
zth 0522d01
fix issue where Some variants wouldnt be handled properly
zth 16a6f0f
complete inline records
zth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot why we have settings checked in at all