refactor: split dir for CLI and dev scripts #6782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gentype again 😂 just opened #6783 |
|
98b5b5f would be better to support third-party tools that need to spawn ReScript binary themselves, but that also means we're adding an official API that we need to keep maintain its compatibility |
cknitt
reviewed
Jun 3, 2024
cometkim
force-pushed
the
split-lib-scripts
branch
3 times, most recently
from
1f539cd to
ee252bc
Compare
|
Thanks a lot! Could you also remove |
cknitt
reviewed
Jun 17, 2024
| ], | ||
| "exports": { | ||
| "./bin_path": "./cli/bin_path.js", | ||
| "./package.json": "./package.json" |
There was a problem hiding this comment.
This is only used once in .github/workflows/prepare_package_upload.js.
I'd prefer to keep .github/workflows/prepare_package_upload.js as it was and just export bin_path here.
There was a problem hiding this comment.
If no consumers exist, it's better to minimize the API exposure. I can convert this back to an import map.
but do we really need to keep this? The `postinstall` hooks is avoided by default in other PMs
cometkim
force-pushed
the
split-lib-scripts
branch
from
a072c46 to
dd9bb74
Compare
cknitt
approved these changes
Jun 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that we already have a managed artifact list for it. but isolating actual artifacts from scripts makes it much easier to maintain, and prevents accidents and dependencies between them.
I added a subpath imports as an easy resolution. That means it is only referenced in internally. Alternatively we can add it as
exportsentry to make it possible to referenced by outside of this package (e.g.require('rescript/bin_path')in https://github.com/rescript-lang/rescript-compiler/blob/f56f5c2/.github/workflows/get_artifact_dir_name.js#L4)