Added PIDCommand.py using ChatGPT translator #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
reviewed
Dec 4, 2023
There was a problem hiding this comment.
When adding stuff to this repo, it's really important to also include the unit tests from wpilibj at https://github.com/wpilibsuite/allwpilib/tree/main/wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command ... which don't exist for this command, never mind then (but keep it in mind for the future)
|
If we're going to lean on ChatGPT for doing this, we should probably do #29 first to make sure we catch some of the more common errors. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add in to the commands now. I used ChatGPT with the prompt in Chief Delphi. Let me know about what mistakes I might have made. I looked over some of the other commands to try to pick up style and imports. Thanks.