Skip to content

Grammar fixes #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Grammar fixes #70

merged 1 commit into from
Aug 8, 2021

Conversation

robyoung
Copy link
Contributor

@robyoung robyoung commented Aug 2, 2021

Mostly minor grammar fixes and grammar consistency improvements.

@robyoung robyoung requested a review from a team as a code owner August 2, 2021 21:05
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Aug 2, 2021
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

bors merge

bors bot added a commit that referenced this pull request Aug 2, 2021
70: Grammar fixes r=adamgreig a=robyoung

Mostly minor grammar fixes and grammar consistency improvements.

Co-authored-by: Rob Young <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 2, 2021

Timed out.

@adamgreig
Copy link
Member

Ah, nuts, this repo is still using Travis CI and it's no longer running. It will need swapping to GHA. I'll try and get to it soon.

@robyoung
Copy link
Contributor Author

robyoung commented Aug 3, 2021

@adamgreig I've taken a stab at switching to GitHub actions here #72
I've stumbled stumbled a bit at actually running it.

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 8, 2021

Build succeeded:

@bors bors bot merged commit 080915f into rust-embedded:master Aug 8, 2021
@adamgreig
Copy link
Member

Changes are live, thanks @robyoung!

@robyoung
Copy link
Contributor Author

robyoung commented Aug 8, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants