Switch to using GitHub Actions for CI #72

robyoung · 2021-08-03T16:24:31Z

I have tried to keep it functionally identical to the travis workflow. This is a bit tricky for me to test.

There are some minor changes though.

Added MSRV of 1.51.0 - I just picked a version out of thin air here.
I could not see an easy way of preventing master branch runs for PRs that have passed so this should run on all.
For deploying to github pages I'm using a 3rd party action. It looks reasonable and just uses the default repo scoped token.

I have tried to keep it functionally identical to the travis workflow. There are some minor changes though. - Added MSRV of 1.51.0 - I just picked a version out of thin air here. - I could not see an easy way of preventing master branch runs for PRs that have passed so this should run on all. - For deploying to github pages I'm using a 3rd party action. It looks reasonable and just uses the default repo scoped token.

rust-highfive · 2021-08-03T16:24:34Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

Please see the contribution instructions for more information.

adamgreig

Wow, thanks for putting this together!

On the whole this looks good but I'd like for it to be slightly more in line with our various other mdbook repos to make ongoing maintenance easier:

The main things to change are:

use cargo to install mdbook and cache it: example
use peaceiris/actions-gh-pages@v3 for gh-pages: example
update bors.toml to require the new check passes, instead of the old one (example)

Hopefully those aren't too bad to do, and thanks again for the PR!

adamgreig · 2021-08-03T22:52:43Z

.github/workflows/ci.yaml

+
+jobs:
+  build:
+    runs-on: ubuntu-latest


Suggested change

runs-on: ubuntu-latest

runs-on: ubuntu-20.04

We've mostly specified specific versions just to ensure there are no surprises when -latest next changes. Same deal applies to the deploy job below, though you could also make that a final and optional step in the build job, I don't mind either way.

robyoung · 2021-08-04T08:04:49Z

That's great. Thanks for the review. I'll take a look at it later today.

robyoung · 2021-08-04T20:07:34Z

@adamgreig I have tried to follow the other book repos as much as possible. However, it looks like this repo does a bit more testing so it feels like it needs to be tested across different versions of rust, which the other workflows do not.

adamgreig

Thanks, looks good! Couple last changes then let's give it a go. Sadly since no actions have been run I don't have a button to try running them for this PR, but once the bors.toml file is updated I can have bors try it instead.

I think we can delete ci/install.sh and the new ci/install-mdbook.sh now?
Currently nightly builds failing will fail CI, but we probably want to allow nightly to fail; there's an example here
.github/bors.toml needs updating or bors will refuse to merge this PR
.travis.yml can be deleted too

.github/workflows/ci.yaml

- Remove redundant install and travis config files - Allow nightly to fail - Update bors.toml (I was sure I had done this)

adamgreig

Great, thank you again! Let's get this merged and hopefully it works, then I'll merge #70 afterwards.

bors merge

72: Switch to using GitHub Actions for CI r=adamgreig a=robyoung I have tried to keep it functionally identical to the travis workflow. This is a bit tricky for me to test. There are some minor changes though. - Added MSRV of 1.51.0 - I just picked a version out of thin air here. - I could not see an easy way of preventing master branch runs for PRs that have passed so this should run on all. - For deploying to github pages I'm using a 3rd party action. It looks reasonable and just uses the default repo scoped token. Co-authored-by: Rob Young <[email protected]> Co-authored-by: Adam Greig <[email protected]>

bors · 2021-08-06T01:52:43Z

Canceled.

Also update format of command line arguments to nm to use double dashes.

adamgreig · 2021-08-06T03:03:17Z

Ugh, that's enough whack-a-mole for tonight. Please don't be put off, this is mostly the test script needing some updates for the latest version of nm. The usual game of fixing one CI bug and then finding the next... If you can work out why arm-none-eabi-gcc isn't being found even though it's apparently installed please go ahead, but otherwise I'll try again tomorrow.

adamgreig · 2021-08-08T01:55:14Z

Whew, that was an endeavour. It turns out you can't copy arm-none-eabi-gcc into a new directory, it needs to stay relative to the directory structure it was extracted from. Who knew.

bors merge

bors · 2021-08-08T01:55:15Z

👎 Rejected by too few approved reviews

adamgreig

bors merge

72: Switch to using GitHub Actions for CI r=adamgreig a=robyoung I have tried to keep it functionally identical to the travis workflow. This is a bit tricky for me to test. There are some minor changes though. - Added MSRV of 1.51.0 - I just picked a version out of thin air here. - I could not see an easy way of preventing master branch runs for PRs that have passed so this should run on all. - For deploying to github pages I'm using a 3rd party action. It looks reasonable and just uses the default repo scoped token. Co-authored-by: Rob Young <[email protected]> Co-authored-by: Adam Greig <[email protected]>

adamgreig · 2021-08-08T01:57:27Z

bors cancel

bors · 2021-08-08T01:57:28Z

Canceled.

adamgreig

bors merge

bors · 2021-08-08T02:16:01Z

Build succeeded:

adamgreig · 2021-08-08T02:16:29Z

🎉 thanks @robyoung!

robyoung · 2021-08-08T21:57:36Z

Woop! Thank you for fixing it. I was totally stumped.

robyoung requested a review from a team as a code owner August 3, 2021 16:24

rust-highfive assigned andre-richter Aug 3, 2021

rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Aug 3, 2021

robyoung mentioned this pull request Aug 3, 2021

Grammar fixes #70

Merged

adamgreig requested changes Aug 3, 2021

View reviewed changes

Follow gha approach used in other book repos

02e2654

adamgreig requested changes Aug 5, 2021

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

robyoung and others added 2 commits August 5, 2021 11:19

Address review comments

5377779

- Remove redundant install and travis config files - Allow nightly to fail - Update bors.toml (I was sure I had done this)

Update .github/workflows/ci.yaml

ebc6f18

adamgreig previously approved these changes Aug 6, 2021

View reviewed changes

CI: Create cache-bin when downloading gcc

cf4391c

adamgreig dismissed their stale review via cf4391c August 6, 2021 01:52

adamgreig added 4 commits August 6, 2021 03:01

CI: Install thumbv7m-none-eabi target

111a8d5

CI: Add llvm-tools-preview to installed toolchain for cargo-binutils

b906053

CI: Fix nm invocation to use full path.

23f639b

CI: Update golden objdumps for new nm syntax

cd0c87a

Also update format of command line arguments to nm to use double dashes.

adamgreig force-pushed the github-actions branch 6 times, most recently from 1e62dd7 to 0182f7e Compare August 7, 2021 00:58

adamgreig force-pushed the github-actions branch 9 times, most recently from c090191 to df623d6 Compare August 8, 2021 01:18

CI: Fix arm-none-eabi-gcc installation

66af410

adamgreig force-pushed the github-actions branch from df623d6 to 66af410 Compare August 8, 2021 01:43

CI: Fix nightly build

3923130

adamgreig previously approved these changes Aug 8, 2021

View reviewed changes

CI: Update exceptions CI for latest Rust and GCC

8847806

adamgreig dismissed their stale review via 8847806 August 8, 2021 02:12

adamgreig approved these changes Aug 8, 2021

View reviewed changes

bors bot merged commit 4dfdf69 into rust-embedded:master Aug 8, 2021

adamgreig mentioned this pull request Aug 8, 2021

Update with newest asm #66

Closed

thejpster mentioned this pull request Aug 9, 2021

GHA support knurling-rs/flip-link#47

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to using GitHub Actions for CI #72

Switch to using GitHub Actions for CI #72

robyoung commented Aug 3, 2021 •

edited

Loading

rust-highfive commented Aug 3, 2021

adamgreig left a comment

adamgreig Aug 3, 2021

robyoung commented Aug 4, 2021

robyoung commented Aug 4, 2021

adamgreig left a comment •

edited

Loading

adamgreig left a comment

bors bot commented Aug 6, 2021

adamgreig commented Aug 6, 2021

adamgreig commented Aug 8, 2021

bors bot commented Aug 8, 2021

adamgreig left a comment

adamgreig commented Aug 8, 2021

bors bot commented Aug 8, 2021

adamgreig left a comment

bors bot commented Aug 8, 2021

adamgreig commented Aug 8, 2021

robyoung commented Aug 8, 2021

Switch to using GitHub Actions for CI #72

Switch to using GitHub Actions for CI #72

Conversation

robyoung commented Aug 3, 2021 • edited Loading

rust-highfive commented Aug 3, 2021

adamgreig left a comment

Choose a reason for hiding this comment

adamgreig Aug 3, 2021

Choose a reason for hiding this comment

robyoung commented Aug 4, 2021

robyoung commented Aug 4, 2021

adamgreig left a comment • edited Loading

Choose a reason for hiding this comment

adamgreig left a comment

Choose a reason for hiding this comment

bors bot commented Aug 6, 2021

adamgreig commented Aug 6, 2021

adamgreig commented Aug 8, 2021

bors bot commented Aug 8, 2021

adamgreig left a comment

Choose a reason for hiding this comment

adamgreig commented Aug 8, 2021

bors bot commented Aug 8, 2021

adamgreig left a comment

Choose a reason for hiding this comment

bors bot commented Aug 8, 2021

adamgreig commented Aug 8, 2021

robyoung commented Aug 8, 2021

robyoung commented Aug 3, 2021 •

edited

Loading

adamgreig left a comment •

edited

Loading