Skip to content

Files are not properly deleted from GitHub Pages #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
17cupsofcoffee opened this issue Feb 9, 2022 · 1 comment
Closed

Files are not properly deleted from GitHub Pages #945

17cupsofcoffee opened this issue Feb 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@17cupsofcoffee
Copy link
Collaborator

I noticed after reverting a change for #912 that when a file is removed from the Zola output, it doesn't get deleted from the master branch - this means that the removed content remains accessible on the site.

For example, I reverted the publishing of newsletter 30 to give people more time to submit, but the HTML for it is still accessible if you have a direct link.

This is apparently an issue with the GitHub action we're using to publish: crazy-max/ghaction-github-pages#153

Is there any reason for us to keep keep_history set to true (the default is false)? We have the history for the site on the source branch and never directly interact with master, so not sure if there's value in having a full history there rather than just having it force pushed every time.

@ozkriff
Copy link
Member

ozkriff commented May 1, 2022

Originally, I enabled keep_history so it'd be easier to double-check the actual changes in Zola's output (I had a couple of issues with my own blog and early Zola). But it seems like Zola has been behaving well for quite some time now, so I don't mind disabling keep_history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants