Allow CI to push file deletions (fixes #945) #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozkriff
approved these changes
May 1, 2022
There was a problem hiding this comment.
Quoting from #945:
Originally, I enabled keep_history so it'd be easier to double-check the actual changes in Zola's output (I had a couple of issues with my own blog and early Zola). But it seems like Zola has been behaving well for quite some time now, so I don't mind disabling keep_history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #945, there's an upstream issue with the CI action we use to publish to GitHub Pages where if
keep_historyis set totrue, files will never be deleted from themasterbranch, even if they're no longer present in Zola's output. The default isfalse, which effectively force pushes tomasterevery time, meaning that it will always reflect exactly what was generated by the most recent Zola run.Given that we never actually utilize the history on the
masterbranch (e.g. if we do a revert, we generally just revert onsourceand let the site republish), I don't think there's much value to keeping the history around? I think it would be worth switching back to the default here.